The branch, v4-7-test has been updated
       via  d7f84b6 s3: smbd: Unix extensions attempts to change wrong field in 
fchown call.
      from  00428e8 s3: smbd: Fix memory leak in vfswrap_getwd()

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-7-test


- Log -----------------------------------------------------------------
commit d7f84b64897192c252b992db0d9b5f06845d53c5
Author: Jeremy Allison <j...@samba.org>
Date:   Mon Apr 9 09:32:23 2018 -0700

    s3: smbd: Unix extensions attempts to change wrong field in fchown call.
    
    Cut and paste error.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13375
    
    Reported-by: Rungta, Vandana <vrun...@amazon.com>
    Signed-off-by: Jeremy Allison <j...@samba.org>
    Reviewed-by: David Disseldorp <dd...@samba.org>
    
    Autobuild-User(master): David Disseldorp <dd...@samba.org>
    Autobuild-Date(master): Tue Apr 10 00:45:56 CEST 2018 on sn-devel-144
    
    (cherry picked from commit 3227b110d065500ed84fc70063da70ab35823a2e)
    
    Autobuild-User(v4-7-test): Karolin Seeger <ksee...@samba.org>
    Autobuild-Date(v4-7-test): Wed Apr 11 02:26:18 CEST 2018 on sn-devel-144

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/trans2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index de6073a..d028dd0 100644
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -7783,10 +7783,10 @@ static NTSTATUS 
smb_set_file_unix_basic(connection_struct *conn,
 
                DEBUG(10,("smb_set_file_unix_basic: SMB_SET_FILE_UNIX_BASIC "
                          "changing group %u for file %s\n",
-                         (unsigned int)set_owner,
+                         (unsigned int)set_grp,
                          smb_fname_str_dbg(smb_fname)));
                if (fsp && fsp->fh->fd != -1) {
-                       ret = SMB_VFS_FCHOWN(fsp, set_owner, (gid_t)-1);
+                       ret = SMB_VFS_FCHOWN(fsp, (uid_t)-1, set_grp);
                } else {
                        /*
                         * UNIX extensions calls must always operate


-- 
Samba Shared Repository

Reply via email to