The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree.
The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-24-0039/flakey.log The failure seems to be in the "samba-nt4" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-24-0039/samba-nt4.stderr https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-24-0039/samba-nt4.stdout The top commit at the time of the failure was: commit 2fa2f132ae3de9a403b2d93d586570f59250de23 Author: Tim Beale <timbe...@catalyst.net.nz> Date: Wed May 16 09:45:32 2018 +1200 dsdb: Avoid calculating the PSO multiple times In a typical user login query, the code tries to work out the PSO 2-3 times - once for the msDS-ResultantPSO attribute, and then again for the msDS-User-Account-Control-Computed & msDS-UserPasswordExpiryTimeComputed constructed attributes. The PSO calculation is reasonably expensive, mostly due to the nested groups calculation. If we've already constructed the msDS-ResultantPSO attribute, then we can save ourselves extra work by just re-fetching the result directly, rather than expanding the nested groups again from scratch. The previous patch improves efficiency when there are no PSOs in the system. This should improve the case where there are PSOs that apply to the users. (Unfortunately, it won't help where there are some PSOs in the system, but no PSO applies to the user being queried). Also updated sam.c so the msDS-ResultantPSO gets calculated first, before the other constructed attributes. Signed-off-by: Tim Beale <timbe...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> Reviewed-by: Garming Sam <garm...@catalyst.net.nz> Autobuild-User(master): Garming Sam <garm...@samba.org> Autobuild-Date(master): Wed May 23 10:09:11 CEST 2018 on sn-devel-144 and the last 50 lines of the stdout log were: [454(2312)/501 at 18m42s] samba.wbinfo_simple.online-status.domain=$DOMAIN(nt4_dc:local) [455(2313)/501 at 18m42s] samba.wbinfo_simple.check-secret.domain=$DOMAIN(nt4_dc:local) [456(2314)/501 at 18m42s] samba.wbinfo_simple.change-secret.domain=$DOMAIN(nt4_dc:local) [457(2315)/501 at 18m42s] samba.wbinfo_simple.check-secret.domain=$DOMAIN(nt4_dc:local) [458(2316)/501 at 18m42s] samba.wbinfo_simple.online-status.domain=$DOMAIN(nt4_dc:local) [459(2317)/501 at 18m42s] samba.wbinfo_simple.domain-users(nt4_dc:local) [460(2318)/501 at 18m42s] samba.wbinfo_simple.domain-groups(nt4_dc:local) [461(2319)/501 at 18m42s] samba.wbinfo_simple.name-to-sid=$DC_USERNAME(nt4_dc:local) [462(2320)/501 at 18m43s] samba.wbinfo_simple.name-to-sid=$DOMAIN/$DC_USERNAME(nt4_dc:local) [463(2321)/501 at 18m43s] samba.wbinfo_simple.user-info=$DOMAIN/$DC_USERNAME(nt4_dc:local) [464(2322)/501 at 18m43s] samba.wbinfo_simple.user-groups=$DOMAIN/$DC_USERNAME(nt4_dc:local) [465(2323)/501 at 18m43s] samba.wbinfo_simple.authenticate=$DOMAIN/$DC_USERNAME%$DC_PASSWORD(nt4_dc:local) [466(2324)/501 at 18m43s] samba.wbinfo_simple.allocate-uid(nt4_dc:local) [467(2325)/501 at 18m43s] samba.wbinfo_simple.allocate-gid(nt4_dc:local) [468(2326)/501 at 18m43s] samba.wbinfo_sids2xids.(nt4_dc:local)(nt4_dc:local) [469(2327)/501 at 18m50s] samba.ntlm_auth.diagnostics(nt4_dc:local)(nt4_dc:local) [470(2328)/501 at 18m50s] samba.ntlm_auth.(nt4_dc:local)(nt4_dc:local) [471(2347)/501 at 18m51s] samba.wbinfo_simple.ping(nt4_member:local) [472(2348)/501 at 18m52s] samba.wbinfo_simple.separator(nt4_member:local) [473(2349)/501 at 18m52s] samba.wbinfo_simple.own-domain(nt4_member:local) [474(2350)/501 at 18m52s] samba.wbinfo_simple.all-domains(nt4_member:local) [475(2351)/501 at 18m52s] samba.wbinfo_simple.trusted-domains(nt4_member:local) [476(2352)/501 at 18m52s] samba.wbinfo_simple.domain-info=BUILTIN(nt4_member:local) [477(2353)/501 at 18m52s] samba.wbinfo_simple.domain-info=$DOMAIN(nt4_member:local) [478(2354)/501 at 18m52s] samba.wbinfo_simple.online-status(nt4_member:local) [479(2355)/501 at 18m52s] samba.wbinfo_simple.online-status.domain=BUILTIN(nt4_member:local) [480(2356)/501 at 18m52s] samba.wbinfo_simple.online-status.domain=$DOMAIN(nt4_member:local) [481(2357)/501 at 18m52s] samba.wbinfo_simple.check-secret.domain=$DOMAIN(nt4_member:local) UNEXPECTED(failure): samba.wbinfo_simple.check-secret.domain=SAMBA-TEST.wbinfo(nt4_member:local) REASON: Exception: Exception: wbcCheckTrustCredentials(SAMBA-TEST): error code was NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND (0xc0000233) failed to call wbcCheckTrustCredentials: WBC_ERR_AUTH_ERROR Could not check secret checking the trust secret for domain SAMBA-TEST via RPC calls failed FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites) A summary with detailed information can be found in: ./bin/ab/summary TOP 10 slowest tests samba3.raw.notify(nt4_dc) -> 99 samba3.smb2.notify(nt4_dc) -> 79 samba3.rpc.samr.passwords.lockout(nt4_dc) -> 62 samba4.rpc.echo on ncacn_np with object(nt4_dc) -> 61 samba3.rpc.samr.passwords.pwdlastset(nt4_dc) -> 48 samba3.smb2.lease(nt4_dc) -> 45 samba3.smb2.oplock(nt4_dc) -> 42 samba3.raw.oplock(nt4_dc) -> 42 samba3.raw.search(nt4_dc) -> 35 samba3.raw.lock(nt4_dc) -> 33 ERROR: test failed with exit code 1