The branch, master has been updated
via a9084dc s3:utils: Remove double error check
from 2916301 ldap_server: Fix CID 1435721 Unchecked return value
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit a9084dce29d9e0e76a3485edfca26add361988ba
Author: Andreas Schneider <[email protected]>
Date: Wed May 23 17:35:15 2018 +0200
s3:utils: Remove double error check
Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Guenther Deschner <[email protected]>
Autobuild-User(master): Günther Deschner <[email protected]>
Autobuild-Date(master): Thu May 24 18:07:03 CEST 2018 on sn-devel-144
-----------------------------------------------------------------------
Summary of changes:
source3/utils/net_dns.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/utils/net_dns.c b/source3/utils/net_dns.c
index 9ee856c..b94bef9 100644
--- a/source3/utils/net_dns.c
+++ b/source3/utils/net_dns.c
@@ -96,10 +96,9 @@ DNS_ERROR DoDNSUpdate(char *pszServerName,
if (!ERR_DNS_IS_OK(err)) goto error;
err = dns_update_transaction(mem_ctx, conn, req, &resp);
- if (!ERR_DNS_IS_OK(err)) goto error;
-
if (!ERR_DNS_IS_OK(err)) {
DEBUG(3,("DoDNSUpdate: unsigned update failed\n"));
+ goto error;
}
if ((dns_response_code(resp->flags) == DNS_NO_ERROR) &&
--
Samba Shared Repository
