The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree.
The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2018-08-14-1256/flakey.log The failure seems to be in the "samba-nt4" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2018-08-14-1256/samba-nt4.stderr https://git.samba.org/autobuild.flakey.sn-devel-144/2018-08-14-1256/samba-nt4.stdout The top commit at the time of the failure was: commit 00513daf78eb29996c81ca4d3be9e71a8e872829 Author: Volker Lendecke <v...@samba.org> Date: Mon Aug 13 15:07:06 2018 +0200 g_lock: Simplify g_lock_trylock While chasing a bug in g_lock (not in master) I saw some opportunity to simplify g_lock_trylock a bit. This is array handling, and array handling is just extremely error-prone. This *might* be a little less efficient or large numbers of READ locks, but this remains to be seen. For now, simplify the code. First, we make two passes now: One to remove ourselves, and the other one to search for conflicts. Mixing up both made it pretty hard for me to follow the code. Second, I've removed the _mylock and mylock pointer/struct logic and replaced it with the "mylock.pid.pid != 0 ? &mylock : NULL" when calling g_lock_store. To me, this focuses the logic whether to add ourselves in one place instead of spreading it around in the whole routine. Signed-off-by: Volker Lendecke <v...@samba.org> Reviewed-by: Jeremy Allison <j...@samba.org> Autobuild-User(master): Volker Lendecke <v...@samba.org> Autobuild-Date(master): Tue Aug 14 11:42:10 CEST 2018 on sn-devel-144 and the last 50 lines of the stdout log were: (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:06 2018 CEST(131813097660000000) => Mon Nov 12 11:56:06 2018 CET(131864937660000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:06 2018 CEST(131813097660000000) => Mon Nov 12 11:56:06 2018 CET(131864937660000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:08 2018 CEST(131813097680000000) => Mon Nov 12 11:56:08 2018 CET(131864937680000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:08 2018 CEST(131813097680000000) => Mon Nov 12 11:56:08 2018 CET(131864937680000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:08 2018 CEST(131813097680000000) => Mon Nov 12 11:56:08 2018 CET(131864937680000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:08 2018 CEST(131813097680000000) => Mon Nov 12 11:56:08 2018 CET(131864937680000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:08 2018 CEST(131813097680000000) => Mon Nov 12 11:56:08 2018 CET(131864937680000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:08 2018 CEST(131813097680000000) => Mon Nov 12 11:56:08 2018 CET(131864937680000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:08 2018 CEST(131813097680000000) => Mon Nov 12 11:56:08 2018 CET(131864937680000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:08 2018 CEST(131813097680000000) => Mon Nov 12 11:56:08 2018 CET(131864937680000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:08 2018 CEST(131813097680000000) => Mon Nov 12 11:56:08 2018 CET(131864937680000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:08 2018 CEST(131813097680000000) => Mon Nov 12 11:56:08 2018 CET(131864937680000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:10 2018 CEST(131813097700000000) => Mon Nov 12 11:56:10 2018 CET(131864937700000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:10 2018 CEST(131813097700000000) => Mon Nov 12 11:56:10 2018 CET(131864937700000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:10 2018 CEST(131813097700000000) => Mon Nov 12 11:56:10 2018 CET(131864937700000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:10 2018 CEST(131813097700000000) => Mon Nov 12 11:56:10 2018 CET(131864937700000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:10 2018 CEST(131813097700000000) => Mon Nov 12 11:56:10 2018 CET(131864937700000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:10 2018 CEST(131813097700000000) => Mon Nov 12 11:56:10 2018 CET(131864937700000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:10 2018 CEST(131813097700000000) => Mon Nov 12 11:56:10 2018 CET(131864937700000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:10 2018 CEST(131813097700000000) => Mon Nov 12 11:56:10 2018 CET(131864937700000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:10 2018 CEST(131813097700000000) => Mon Nov 12 11:56:10 2018 CET(131864937700000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:12 2018 CEST(131813097720000000) => Mon Nov 12 11:56:12 2018 CET(131864937720000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:12 2018 CEST(131813097720000000) => Mon Nov 12 11:56:12 2018 CET(131864937720000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:12 2018 CEST(131813097720000000) => Mon Nov 12 11:56:12 2018 CET(131864937720000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:12 2018 CEST(131813097720000000) => Mon Nov 12 11:56:12 2018 CET(131864937720000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:12 2018 CEST(131813097720000000) => Mon Nov 12 11:56:12 2018 CET(131864937720000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:12 2018 CEST(131813097720000000) => Mon Nov 12 11:56:12 2018 CET(131864937720000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:12 2018 CEST(131813097720000000) => Mon Nov 12 11:56:12 2018 CET(131864937720000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:12 2018 CEST(131813097720000000) => Mon Nov 12 11:56:12 2018 CET(131864937720000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:12 2018 CEST(131813097720000000) => Mon Nov 12 11:56:12 2018 CET(131864937720000000) (../source4/torture/smb2/util.c:158) change_time not setup correctly: Thu Sep 13 12:56:14 2018 CEST(131813097740000000) => Mon Nov 12 11:56:14 2018 CET(131864937740000000) UNEXPECTED(failure): samba3.smb2.notify.mask(nt4_dc) REASON: Exception: Exception: ERROR: nchanges=1 action=2 expectedAction=1 filter=0x00000004 FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites) A summary with detailed information can be found in: ./bin/ab/summary TOP 10 slowest tests samba3.raw.notify(nt4_dc) -> 105 samba3.blackbox.net.rpc.conf(nt4_dc) -> 73 samba3.raw.search(nt4_dc) -> 65 samba3.blackbox.net.local.conf(nt4_dc:local) -> 54 samba3.raw.oplock(nt4_dc) -> 47 samba3.raw.lock(nt4_dc) -> 34 samba3.smbtorture_s3.crypt_client(nt4_dc).OPLOCK1(nt4_dc) -> 31 samba3.base.dir2(nt4_dc) -> 27 samba3.base.lock(nt4_dc) -> 22 samba3.raw.search(nt4_dc) -> 21 ERROR: test failed with exit code 1