Hi Metze, I wanted to rename the python module because the naming didn't seem consistent with any of the other python bindings Samba has. I think 'libsmb_samba_internal' made sense when it was unused by any of the samba python code (except some test code). But now (well, soon) these Python bindings will be used by the samba-tool code. It looks a bit strange in samba-tool to have:
conn = libsmb_samba_internal.Conn(server) E.g. my latest patches start to use the new bindings in more places: https://gitlab.com/catalyst-samba/samba/commits/timb-pysmb-latest But maybe I've misunderstood something. Why do you want to keep the libsmb_samba_internal name? Cheers, Tim On 8/01/19 5:54 PM, Stefan Metzmacher wrote: > Hi Tim, > >> diff --git a/source3/wscript_build b/source3/wscript_build >> index a8ea8e581df..9d188a8d36a 100644 >> --- a/source3/wscript_build >> +++ b/source3/wscript_build >> @@ -1323,7 +1323,7 @@ for env in bld.gen_python_environments(): >> bld.SAMBA3_PYTHON('pylibsmb', >> source='libsmb/pylibsmb.c', >> deps='smbclient samba-credentials %s' % pycredentials, >> - realname='samba/samba3/libsmb_samba_internal.so' >> + realname='samba/samba3/libsmb.so' >> ) > What's wrong with libsmb_samba_internal? I'd keep the name. > > metze >
