The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree.
The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2019-03-31-1259/flakey.log The failure seems to be in the "samba-nt4" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2019-03-31-1259/samba-nt4.stderr https://git.samba.org/autobuild.flakey.sn-devel-144/2019-03-31-1259/samba-nt4.stdout The top commit at the time of the failure was: commit 865b7b0c7d2ba7fa0a045586d1e83a72028a0864 Author: Philipp Gesang <[email protected]> Date: Thu Feb 14 10:17:28 2019 +0100 libcli: permit larger values of DataLength in SMB2_ENCRYPTION_CAPABILITIES of negotiate response Certain Netapp versions are sending SMB2_ENCRYPTION_CAPABILITIES structures containing DataLength field that includes the padding [0]. Microsoft has since clarified that only values smaller than the size are considered invalid [1]. While parsing the NegotiateContext it is ensured that DataLength does not exceed the message bounds. Also, the value is not actually used anywhere outside the validation. Thus values greater than the actual data size are safe to use. This patch makes Samba fail only on values that are too small for the (fixed size) payload. [0] https://lists.samba.org/archive/samba/2019-February/221139.html [1] https://lists.samba.org/archive/cifs-protocol/2019-March/003210.html BUG: https://bugzilla.samba.org/show_bug.cgi?id=13869 Signed-off-by: Philipp Gesang <[email protected]> Reviewed-by: Ralph Böhme <[email protected]> Reviewed-by: Jeremy Allison <[email protected]> Autobuild-User(master): Jeremy Allison <[email protected]> Autobuild-Date(master): Sun Mar 31 01:11:09 UTC 2019 on sn-devel-144 and the last 50 lines of the stdout log were: [191(1087)/588 at 13m8s] samba3.raw.search(nt4_dc) [192(1095)/588 at 14m21s] samba3.raw.seek(nt4_dc) [193(1096)/588 at 14m21s] samba3.raw.sfileinfo.bug(nt4_dc) [194(1096)/588 at 14m22s] samba3.raw.streams(nt4_dc) [195(1109)/588 at 14m27s] samba3.raw.unlink(nt4_dc) [196(1112)/588 at 14m28s] samba3.raw.write(nt4_dc) [197(1116)/588 at 14m29s] samba3.raw.samba3hide(nt4_dc) [198(1117)/588 at 14m30s] samba3.raw.samba3badpath(nt4_dc) [199(1118)/588 at 14m30s] samba3.raw.sfileinfo.rename(nt4_dc) [200(1119)/588 at 14m31s] samba3.raw.session plain(nt4_dc) [201(1121)/588 at 14m32s] samba3.raw.session enc(nt4_dc) [202(1123)/588 at 14m32s] samba3.raw.samba3caseinsensitive(nt4_dc) [203(1124)/588 at 14m32s] samba3.raw.samba3posixtimedlock(nt4_dc) [204(1125)/588 at 14m38s] samba3.raw.samba3rootdirfid(nt4_dc) [205(1126)/588 at 14m39s] samba3.raw.sfileinfo.end-of-file(nt4_dc) [206(1127)/588 at 14m39s] samba3.raw.samba3checkfsp(nt4_dc) [207(1128)/588 at 14m40s] samba3.raw.samba3closeerr(nt4_dc) [208(1129)/588 at 14m40s] samba3.raw.samba3oplocklogoff(nt4_dc) [209(1130)/588 at 14m41s] samba3.raw.samba3badnameblob(nt4_dc) [210(1131)/588 at 14m41s] samba3.smb2.getinfo(nt4_dc) [211(1137)/588 at 14m42s] samba3.smb2.lock aio(nt4_dc) [212(1158)/588 at 14m47s] samba3.smb2.lock(nt4_dc) [213(1179)/588 at 14m51s] samba3.smb2.read(nt4_dc) [214(1183)/588 at 14m52s] samba3.smb2.aio_delay(nt4_dc) [215(1184)/588 at 14m56s] samba3.smb2.create(nt4_dc) [216(1197)/588 at 14m59s] samba3.smb2.twrp(nt4_dc) [217(1197)/588 at 14m59s] samba3.smb2.acls(nt4_dc) [218(1210)/588 at 15m4s] samba3.smb2.notify(nt4_dc) smbtorture 4.11.0pre1-DEVELOPERBUILD Using seed 1554029879 TESTING VALIDITY OF CHANGE NOTIFY REQUEST UNEXPECTED(failure): samba3.smb2.notify.valid-req(nt4_dc) REASON: Exception: Exception: (../../source4/torture/smb2/notify.c:163) wrong value for n.out.num_changes 0x2 should be 0x3 FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites) A summary with detailed information can be found in: ./bin/ab/summary TOP 10 slowest tests samba3.raw.notify(nt4_dc) -> 112 samba3.raw.search(nt4_dc) -> 73 samba3.blackbox.net.rpc.conf(nt4_dc) -> 68 samba3.base.dir2(nt4_dc) -> 55 samba3.raw.oplock(nt4_dc) -> 50 samba3.blackbox.net.local.conf(nt4_dc:local) -> 37 samba3.raw.lock(nt4_dc) -> 35 samba3.smbtorture_s3.crypt_client.OPLOCK1(nt4_dc) -> 31 samba3.raw.search(nt4_dc) -> 26 samba3.base.defer_open(nt4_dc) -> 16 ERROR: test failed with exit code 1
