The branch, master has been updated
via 2ae75184fcb Add PrimaryGroupId to group array in DC response
via 37009984197 selftest: check for PrimaryGroupId in DC returned group
array
via 60afe949c3e selftest: remote_pac: s/s2u4self/s4u2self/g
from 9d5044fe97b s3:modules: Use hash_inode() in vfs_streams_xattr
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 2ae75184fcb5dc90602aeef113d4c13540073324
Author: Isaac Boukris <[email protected]>
Date: Wed Apr 3 19:45:02 2019 +0300
Add PrimaryGroupId to group array in DC response
This is a simplified version of the original patch by:
Felix Botner <[email protected]>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11362
Pair-Programmed-With: Stefan Metzmacher <[email protected]>
Signed-off-by: Isaac Boukris <[email protected]>
Signed-off-by: Stefan Metzmacher <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
Autobuild-User(master): Stefan Metzmacher <[email protected]>
Autobuild-Date(master): Wed Jul 3 13:52:55 UTC 2019 on sn-devel-184
commit 3700998419738caa1ca8672fbf5dbaccaaa498fa
Author: Isaac Boukris <[email protected]>
Date: Fri May 31 17:22:50 2019 +0300
selftest: check for PrimaryGroupId in DC returned group array
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11362
Signed-off-by: Isaac Boukris <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
Reviewed-by: Stefan Metzmacher <[email protected]>
commit 60afe949c3e664f81c9b0db9c54f701aa2874a5e
Author: Isaac Boukris <[email protected]>
Date: Fri May 31 20:02:30 2019 +0300
selftest: remote_pac: s/s2u4self/s4u2self/g
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11362
Signed-off-by: Isaac Boukris <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
Reviewed-by: Stefan Metzmacher <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
auth/auth_sam_reply.c | 8 ++-
source4/torture/rpc/remote_pac.c | 114 +++++++++++++++++++++++++++------------
2 files changed, 87 insertions(+), 35 deletions(-)
Changeset truncated at 500 lines:
diff --git a/auth/auth_sam_reply.c b/auth/auth_sam_reply.c
index bd695151dc0..b5b6362dc93 100644
--- a/auth/auth_sam_reply.c
+++ b/auth/auth_sam_reply.c
@@ -89,7 +89,7 @@ static NTSTATUS
auth_convert_user_info_dc_sambaseinfo(TALLOC_CTX *mem_ctx,
sam->groups.count = 0;
sam->groups.rids = NULL;
- if (user_info_dc->num_sids > 2) {
+ if (user_info_dc->num_sids > PRIMARY_GROUP_SID_INDEX) {
size_t i;
sam->groups.rids = talloc_array(mem_ctx, struct
samr_RidWithAttribute,
user_info_dc->num_sids);
@@ -97,7 +97,7 @@ static NTSTATUS
auth_convert_user_info_dc_sambaseinfo(TALLOC_CTX *mem_ctx,
if (sam->groups.rids == NULL)
return NT_STATUS_NO_MEMORY;
- for (i=2; i<user_info_dc->num_sids; i++) {
+ for (i=PRIMARY_GROUP_SID_INDEX; i<user_info_dc->num_sids; i++) {
struct dom_sid *group_sid = &user_info_dc->sids[i];
if (!dom_sid_in_domain(sam->domain_sid, group_sid)) {
/* We handle this elsewhere */
@@ -451,6 +451,10 @@ NTSTATUS make_user_info_dc_netlogon_validation(TALLOC_CTX
*mem_ctx,
}
for (i = 0; i < base->groups.count; i++) {
+ /* Skip primary group, already added above */
+ if (base->groups.rids[i].rid == base->primary_gid) {
+ continue;
+ }
user_info_dc->sids[user_info_dc->num_sids] = *base->domain_sid;
if
(!sid_append_rid(&user_info_dc->sids[user_info_dc->num_sids],
base->groups.rids[i].rid)) {
return NT_STATUS_INVALID_PARAMETER;
diff --git a/source4/torture/rpc/remote_pac.c b/source4/torture/rpc/remote_pac.c
index d915427f1b4..7a5cda74b74 100644
--- a/source4/torture/rpc/remote_pac.c
+++ b/source4/torture/rpc/remote_pac.c
@@ -39,8 +39,8 @@
#define TEST_MACHINE_NAME_BDC "torturepacbdc"
#define TEST_MACHINE_NAME_WKSTA "torturepacwksta"
#define TEST_MACHINE_NAME_WKSTA_DES "torturepacwkdes"
-#define TEST_MACHINE_NAME_S2U4SELF_BDC "tests2u4selfbdc"
-#define TEST_MACHINE_NAME_S2U4SELF_WKSTA "tests2u4selfwk"
+#define TEST_MACHINE_NAME_S4U2SELF_BDC "tests4u2selfbdc"
+#define TEST_MACHINE_NAME_S4U2SELF_WKSTA "tests4u2selfwk"
struct pac_data {
DATA_BLOB pac_blob;
@@ -614,10 +614,47 @@ static bool test_PACVerify_workstation_des(struct
torture_context *tctx,
NETLOGON_NEG_AUTH2_ADS_FLAGS);
}
-
-/* Check various ways to get the PAC, in particular check the group membership
and other details between the PAC from a normal kinit, S2U4Self and a SamLogon
*/
#ifdef SAMBA4_USES_HEIMDAL
-static bool test_S2U4Self(struct torture_context *tctx,
+static NTSTATUS check_primary_group_in_validation(TALLOC_CTX *mem_ctx,
+ uint16_t validation_level,
+ const union netr_Validation
*validation)
+{
+ const struct netr_SamBaseInfo *base = NULL;
+ int i;
+ switch (validation_level) {
+ case 2:
+ if (!validation || !validation->sam2) {
+ return NT_STATUS_INVALID_PARAMETER;
+ }
+ base = &validation->sam2->base;
+ break;
+ case 3:
+ if (!validation || !validation->sam3) {
+ return NT_STATUS_INVALID_PARAMETER;
+ }
+ base = &validation->sam3->base;
+ break;
+ case 6:
+ if (!validation || !validation->sam6) {
+ return NT_STATUS_INVALID_PARAMETER;
+ }
+ base = &validation->sam6->base;
+ break;
+ default:
+ return NT_STATUS_INVALID_LEVEL;
+ }
+
+ for (i = 0; i < base->groups.count; i++) {
+ if (base->groups.rids[i].rid == base->primary_gid) {
+ return NT_STATUS_OK;
+ }
+ }
+ return NT_STATUS_INVALID_PARAMETER;
+}
+
+/* Check various ways to get the PAC, in particular check the group membership
and
+ * other details between the PAC from a normal kinit, S4U2Self and a SamLogon
*/
+static bool test_S4U2Self(struct torture_context *tctx,
struct dcerpc_pipe *p1,
struct cli_credentials *credentials,
enum netr_SchannelType secure_channel_type,
@@ -646,7 +683,7 @@ static bool test_S2U4Self(struct torture_context *tctx,
struct auth4_context *auth_context;
struct auth_session_info *kinit_session_info;
- struct auth_session_info *s2u4self_session_info;
+ struct auth_session_info *s4u2self_session_info;
struct auth_user_info_dc *netlogon_user_info_dc;
struct netr_NetworkInfo ninfo;
@@ -744,7 +781,7 @@ static bool test_S2U4Self(struct torture_context *tctx,
torture_assert_ntstatus_ok(tctx, status, "gensec_session_info failed");
- /* Now do the dance with S2U4Self */
+ /* Now do the dance with S4U2Self */
/* Wipe out any existing ccache */
cli_credentials_invalidate_ccache(client_creds, CRED_SPECIFIED);
@@ -803,7 +840,7 @@ static bool test_S2U4Self(struct torture_context *tctx,
/* Extract the PAC using Samba's code */
- status = gensec_session_info(gensec_server_context,
gensec_server_context, &s2u4self_session_info);
+ status = gensec_session_info(gensec_server_context,
gensec_server_context, &s4u2self_session_info);
torture_assert_ntstatus_ok(tctx, status, "gensec_session_info failed");
cli_credentials_get_ntlm_username_domain(client_creds, tctx,
@@ -872,21 +909,32 @@ static bool test_S2U4Self(struct torture_context *tctx,
torture_assert_ntstatus_ok(tctx, status,
"make_user_info_dc_netlogon_validation failed");
+ /* Check that the primary group is present in validation's RID array */
+ status = check_primary_group_in_validation(tmp_ctx,
r.in.validation_level, r.out.validation);
+ torture_assert_ntstatus_ok(tctx, status,
"check_primary_group_in_validation failed");
+
+ /* Check that the primary group is not duplicated in user_info_dc SID
array */
+ for (i = 2; i < netlogon_user_info_dc->num_sids; i++) {
+ torture_assert(tctx,
!dom_sid_equal(&netlogon_user_info_dc->sids[1],
+
&netlogon_user_info_dc->sids[i]),
+ "Duplicate PrimaryGroupId in return SID array");
+ }
+
torture_assert_str_equal(tctx,
netlogon_user_info_dc->info->account_name == NULL ? "" :
netlogon_user_info_dc->info->account_name,
kinit_session_info->info->account_name,
"Account name differs for kinit-based PAC");
torture_assert_str_equal(tctx,netlogon_user_info_dc->info->account_name
== NULL ? "" : netlogon_user_info_dc->info->account_name,
- s2u4self_session_info->info->account_name,
"Account name differs for S2U4Self");
+ s4u2self_session_info->info->account_name,
"Account name differs for S4U2Self");
torture_assert_str_equal(tctx, netlogon_user_info_dc->info->full_name
== NULL ? "" : netlogon_user_info_dc->info->full_name,
kinit_session_info->info->full_name, "Full name differs for kinit-based PAC");
- torture_assert_str_equal(tctx, netlogon_user_info_dc->info->full_name
== NULL ? "" : netlogon_user_info_dc->info->full_name,
s2u4self_session_info->info->full_name, "Full name differs for S2U4Self");
+ torture_assert_str_equal(tctx, netlogon_user_info_dc->info->full_name
== NULL ? "" : netlogon_user_info_dc->info->full_name,
s4u2self_session_info->info->full_name, "Full name differs for S4U2Self");
torture_assert_int_equal(tctx, netlogon_user_info_dc->num_sids,
kinit_session_info->torture->num_dc_sids, "Different numbers of domain groups
for kinit-based PAC");
- torture_assert_int_equal(tctx, netlogon_user_info_dc->num_sids,
s2u4self_session_info->torture->num_dc_sids, "Different numbers of domain
groups for S2U4Self");
+ torture_assert_int_equal(tctx, netlogon_user_info_dc->num_sids,
s4u2self_session_info->torture->num_dc_sids, "Different numbers of domain
groups for S4U2Self");
builtin_domain = dom_sid_parse_talloc(tmp_ctx, SID_BUILTIN);
for (i = 0; i < kinit_session_info->torture->num_dc_sids; i++) {
torture_assert(tctx,
dom_sid_equal(&netlogon_user_info_dc->sids[i],
&kinit_session_info->torture->dc_sids[i]), "Different domain groups for
kinit-based PAC");
- torture_assert(tctx,
dom_sid_equal(&netlogon_user_info_dc->sids[i],
&s2u4self_session_info->torture->dc_sids[i]), "Different domain groups for
S2U4Self");
- torture_assert(tctx, !dom_sid_in_domain(builtin_domain,
&s2u4self_session_info->torture->dc_sids[i]), "Returned BUILTIN domain in
groups for S2U4Self");
+ torture_assert(tctx,
dom_sid_equal(&netlogon_user_info_dc->sids[i],
&s4u2self_session_info->torture->dc_sids[i]), "Different domain groups for
S4U2Self");
+ torture_assert(tctx, !dom_sid_in_domain(builtin_domain,
&s4u2self_session_info->torture->dc_sids[i]), "Returned BUILTIN domain in
groups for S4U2Self");
torture_assert(tctx, !dom_sid_in_domain(builtin_domain,
&kinit_session_info->torture->dc_sids[i]), "Returned BUILTIN domain in groups
kinit-based PAC");
torture_assert(tctx, !dom_sid_in_domain(builtin_domain,
&netlogon_user_info_dc->sids[i]), "Returned BUILTIN domian in groups from
NETLOGON SamLogon reply");
}
@@ -894,39 +942,39 @@ static bool test_S2U4Self(struct torture_context *tctx,
return true;
}
-static bool test_S2U4Self_bdc_arcfour(struct torture_context *tctx,
+static bool test_S4U2Self_bdc_arcfour(struct torture_context *tctx,
struct dcerpc_pipe *p,
struct cli_credentials *credentials)
{
- return test_S2U4Self(tctx, p, credentials, SEC_CHAN_BDC,
- TEST_MACHINE_NAME_S2U4SELF_BDC,
+ return test_S4U2Self(tctx, p, credentials, SEC_CHAN_BDC,
+ TEST_MACHINE_NAME_S4U2SELF_BDC,
NETLOGON_NEG_AUTH2_ADS_FLAGS);
}
-static bool test_S2U4Self_bdc_aes(struct torture_context *tctx,
+static bool test_S4U2Self_bdc_aes(struct torture_context *tctx,
struct dcerpc_pipe *p,
struct cli_credentials *credentials)
{
- return test_S2U4Self(tctx, p, credentials, SEC_CHAN_BDC,
- TEST_MACHINE_NAME_S2U4SELF_BDC,
+ return test_S4U2Self(tctx, p, credentials, SEC_CHAN_BDC,
+ TEST_MACHINE_NAME_S4U2SELF_BDC,
NETLOGON_NEG_AUTH2_ADS_FLAGS |
NETLOGON_NEG_SUPPORTS_AES);
}
-static bool test_S2U4Self_workstation_arcfour(struct torture_context *tctx,
+static bool test_S4U2Self_workstation_arcfour(struct torture_context *tctx,
struct dcerpc_pipe *p,
struct cli_credentials
*credentials)
{
- return test_S2U4Self(tctx, p, credentials, SEC_CHAN_WKSTA,
- TEST_MACHINE_NAME_S2U4SELF_WKSTA,
+ return test_S4U2Self(tctx, p, credentials, SEC_CHAN_WKSTA,
+ TEST_MACHINE_NAME_S4U2SELF_WKSTA,
NETLOGON_NEG_AUTH2_ADS_FLAGS);
}
-static bool test_S2U4Self_workstation_aes(struct torture_context *tctx,
+static bool test_S4U2Self_workstation_aes(struct torture_context *tctx,
struct dcerpc_pipe *p,
struct cli_credentials *credentials)
{
- return test_S2U4Self(tctx, p, credentials, SEC_CHAN_WKSTA,
- TEST_MACHINE_NAME_S2U4SELF_WKSTA,
+ return test_S4U2Self(tctx, p, credentials, SEC_CHAN_WKSTA,
+ TEST_MACHINE_NAME_S4U2SELF_WKSTA,
NETLOGON_NEG_AUTH2_ADS_FLAGS |
NETLOGON_NEG_SUPPORTS_AES);
}
#endif
@@ -957,20 +1005,20 @@ struct torture_suite *torture_rpc_remote_pac(TALLOC_CTX
*mem_ctx)
torture_rpc_tcase_add_test_join(tcase, "verify-sig",
test_PACVerify_workstation_des);
#ifdef SAMBA4_USES_HEIMDAL
tcase = torture_suite_add_machine_bdc_rpc_iface_tcase(suite,
"netr-bdc-arcfour",
-
&ndr_table_netlogon, TEST_MACHINE_NAME_S2U4SELF_BDC);
- torture_rpc_tcase_add_test_creds(tcase, "s2u4self-arcfour",
test_S2U4Self_bdc_arcfour);
+
&ndr_table_netlogon, TEST_MACHINE_NAME_S4U2SELF_BDC);
+ torture_rpc_tcase_add_test_creds(tcase, "s4u2self-arcfour",
test_S4U2Self_bdc_arcfour);
tcase = torture_suite_add_machine_bdc_rpc_iface_tcase(suite,
"netr-bcd-aes",
-
&ndr_table_netlogon, TEST_MACHINE_NAME_S2U4SELF_BDC);
- torture_rpc_tcase_add_test_creds(tcase, "s2u4self-aes",
test_S2U4Self_bdc_aes);
+
&ndr_table_netlogon, TEST_MACHINE_NAME_S4U2SELF_BDC);
+ torture_rpc_tcase_add_test_creds(tcase, "s4u2self-aes",
test_S4U2Self_bdc_aes);
tcase = torture_suite_add_machine_workstation_rpc_iface_tcase(suite,
"netr-mem-arcfour",
-
&ndr_table_netlogon, TEST_MACHINE_NAME_S2U4SELF_WKSTA);
- torture_rpc_tcase_add_test_creds(tcase, "s2u4self-arcfour",
test_S2U4Self_workstation_arcfour);
+
&ndr_table_netlogon, TEST_MACHINE_NAME_S4U2SELF_WKSTA);
+ torture_rpc_tcase_add_test_creds(tcase, "s4u2self-arcfour",
test_S4U2Self_workstation_arcfour);
tcase = torture_suite_add_machine_workstation_rpc_iface_tcase(suite,
"netr-mem-aes",
-
&ndr_table_netlogon, TEST_MACHINE_NAME_S2U4SELF_WKSTA);
- torture_rpc_tcase_add_test_creds(tcase, "s2u4self-aes",
test_S2U4Self_workstation_aes);
+
&ndr_table_netlogon, TEST_MACHINE_NAME_S4U2SELF_WKSTA);
+ torture_rpc_tcase_add_test_creds(tcase, "s4u2self-aes",
test_S4U2Self_workstation_aes);
#endif
return suite;
}
--
Samba Shared Repository
