The branch, master has been updated
       via  18e2d6b0098 s3/libsmb: clang: Fix 'warning: Value stored to 'p' is 
never read'
       via  1ca110b5476 s3/passdb: clang: Value stored to 'c' is never read
       via  2138bd93bb2 s3/libsmb: clang: value stored to 'idx_current' is 
never read
       via  388f280448b s3/passdb: clang: Fix warning: Value stored to 
'acct_ctrl' is never read
       via  6ae0fd5a348 s3/lib/netapi: clang: Fix 'Value stored during 
initialization is never read'
       via  9c16d8fb246 s3/rpc_client: clang: Fix 'Value stored during 
initialization is never read'
       via  58400d6e65f lib/talloc: clang: Fix 'Value stored during its 
initialization is never read'
       via  32d487d0746 s3/libads: clang: Fix 'Value stored during its 
initialization is never read'
       via  a3b9986fac2 s3/lib/netapi: clang: Fix 'Value stored during 
initialization is never read'
       via  25c92111dcb s3/lib/netapi: clang: Fix 'Value stored during 
initialization is never read'
       via  8ea0835a6cb s3/auth: clang: Fix 'Value stored during its 
initialization is never read'
       via  9759e96ff1d s3/auth: clang: Fix 'Value stored during its 
initialization is never read'
       via  50ff6c965f2 s3/libsmb: clang: Fix 'Value stored during its 
initialization is never read'
       via  eb3ba3eeaa2 s3/libads: clang: Fix 'Value stored during 
initialization is never read'
       via  35e0122e7c7 s3/libads: clang: Fix 'Value stored to 'nt_status' is 
never read'
       via  fba666cf2a5 s3/passed: clang: Fix 'Value stored during its 
initialization is never read'
       via  b08ec1903d2 s3/rpc_client: clang: 'Value stored during its 
initialization is never read'
       via  ae2e9ce5c36 s3/rpc_client: clang: Fix 'Value stored during 
initialization is never read'
       via  38aafe0d6bb s3/passdb: clang: Fix 'Value stored during its 
initialization is never read'
       via  299eff4ac90 s3/passdb: clang: Fix 'Value stored during 
initialization is never read'
       via  2d47067c863 s3/passdb: clang: Fix 'Value stored during 
initialization is never read'
       via  752f5b63d0c s3/passdb: clang: Fix 'Value stored during its 
initialization is never read'
       via  c534b05c8d4 s4/winbind: clang: Fixes 'Value stored during its 
initialization is never read'
       via  6831b6ba6f5 s3/rpc_client: clang: Fix 'Value stored during 
initialization is never read'
       via  368d0cecc0b s3/groupdb: clang: 'Value stored during its 
initialization is never read'
       via  6055134330d s3/groupdb: clang: Fix 'Value stored during its 
initialization is never read'
       via  5550367e46d s4-torture: remove duplicate NDR_PRINT
       via  fd20153e8b0 s4-torture: dump ndr packet in ndr tests with high log 
level
       via  86a0e4850e0 librpc/ndr: add ndr_print_netlogon_samlogon_response()
      from  1ec030398bd s3: VFS: Complete the replacement of SMB_VFS_UNLINK() 
-> SMB_VFS_UNLINKAT().

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 18e2d6b0098232c2bd8d51320095d35bd7301920
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Aug 15 14:30:29 2019 +0100

    s3/libsmb: clang: Fix 'warning: Value stored to 'p' is never read'
    
    Fixes:
    
    source3/libsmb/cliconnect.c:649:2: warning: Value stored to 'p' is never 
read <--[clang]
            p += ret;
            ^    ~~~
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>
    
    Autobuild-User(master): Jeremy Allison <j...@samba.org>
    Autobuild-Date(master): Thu Sep 26 19:59:24 UTC 2019 on sn-devel-184

commit 1ca110b547622f788d94530e0e3432845c2943bf
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Sep 5 14:42:41 2019 +0000

    s3/passdb: clang: Value stored to 'c' is never read
    
    source3/passdb/pdb_smbpasswd.c:405:4: warning: Value stored to 'c' is never 
read <--[clang]
                            c = '\0';
                            ^   ~~~~
    /home/samba/samba/source3/passdb/pdb_smbpasswd.c:809:4: warning: Value 
stored to 'c' is never read <--[clang]
                            c = '\0';
                            ^   ~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 2138bd93bb258f2dde2c279a0ba80f9a40737aed
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Sep 5 14:16:57 2019 +0000

    s3/libsmb: clang: value stored to 'idx_current' is never read
    
    Fixes:
    
    source3/libsmb/trusts_util.c:602:2: warning: Value stored to 'idx_current' 
is never read <--[clang]
            idx_current = idx;
            ^             ~~~
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 388f280448b9ea459d8d884dbbbce54ab930da7b
Author: Noel Power <noel.po...@suse.com>
Date:   Fri Sep 6 13:46:40 2019 +0000

    s3/passdb: clang: Fix warning: Value stored to 'acct_ctrl' is never read
    
    Fixes:
    
    source3/passdb/pdb_ldap.c:922:3: warning: Value stored to 'acct_ctrl' is 
never read <--[clang]
                    acct_ctrl |= ACB_NORMAL;
                    ^            ~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 6ae0fd5a348224b2a7942c81c4ef21bf11205d62
Author: Noel Power <noel.po...@suse.com>
Date:   Tue Sep 17 14:43:20 2019 +0000

    s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/lib/netapi/user.c:1290:11: warning: Value stored to 'status' during 
its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    source3/lib/netapi/user.c:1610:11: warning: Value stored to 'status' during 
its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    
    source3/lib/netapi/user.c:2990:11: warning: Value stored to 'status' during 
its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    source3/lib/netapi/user.c:3184:11: warning: Value stored to 'status' during 
its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    source3/lib/netapi/user.c:3522:11: warning: Value stored to 'status' during 
its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 9c16d8fb246911d7bbd576d7e6bce0c8fb39929f
Author: Noel Power <noel.po...@suse.com>
Date:   Tue Sep 17 14:20:03 2019 +0000

    s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/rpc_client/cli_winreg.c:728:11: warning: Value stored to 'status' 
during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    /source3/rpc_client/cli_winreg.c:897:11: warning: Value stored to 'status' 
during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 58400d6e65f70a256ebd900c3eca1c945b71be10
Author: Noel Power <noel.po...@suse.com>
Date:   Tue Sep 17 08:13:00 2019 +0000

    lib/talloc: clang: Fix 'Value stored during its initialization is never 
read'
    
    Fixes:
    
    ib/talloc/pytalloc_util.c:245:8: warning: Value stored to 'type_obj' during 
its initialization is never read <--[clang]
            void *type_obj = talloc_check_name(ptr, type_name);
                  ^~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 32d487d0746b0fc8888ed37dfbfae3245b269dd7
Author: Noel Power <noel.po...@suse.com>
Date:   Tue Sep 17 08:05:28 2019 +0000

    s3/libads: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/libads/ldap.c:370:11: warning: Value stored to 'status' during its 
initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/libads/ldap.c:417:11: warning: Value stored to 'status' during its 
initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/libads/ldap.c:1783:13: warning: Value stored to 'ret' during its 
initialization is never read <--[clang]
            ADS_STATUS ret = ADS_ERROR(LDAP_SUCCESS);
                       ^~~   ~~~~~~~~~~~~~~~~~~~~~~~
    source3/libads/ldap.c:1862:13: warning: Value stored to 'ret' during its 
initialization is never read <--[clang]
            ADS_STATUS ret = ADS_ERROR(LDAP_SUCCESS);
                       ^~~   ~~~~~~~~~~~~~~~~~~~~~~~
    4 warnings generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit a3b9986fac270797be4dbd3d453add9d2107e953
Author: Noel Power <noel.po...@suse.com>
Date:   Mon Sep 16 10:43:54 2019 +0000

    s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/lib/netapi/getdc.c:173:11: warning: Value stored to 'status' during 
its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 25c92111dcb646f8537d89fc2d091ee3c5753d56
Author: Noel Power <noel.po...@suse.com>
Date:   Mon Sep 16 10:35:49 2019 +0000

    s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/lib/netapi/group.c:1383:11: warning: Value stored to '
    status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    samba/source3/lib/netapi/group.c:1521:11: warning: Value stored to '
    status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    samba/source3/lib/netapi/group.c:1718:11: warning: Value stored to '
    status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    3 warnings generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 8ea0835a6cbe8721780929b9946de65cd87dc26d
Author: Noel Power <noel.po...@suse.com>
Date:   Fri Sep 13 13:57:16 2019 +0000

    s3/auth: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/auth/auth.c:38:35: warning: Value stored to 'entry' during its 
initialization is never read <--[clang]
            struct auth_init_function_entry *entry = auth_backends;
                                             ^~~~~   ~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 9759e96ff1dc8741222eb6794dc01bd5b65c282d
Author: Noel Power <noel.po...@suse.com>
Date:   Fri Sep 13 13:54:11 2019 +0000

    s3/auth: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/auth/auth_util.c:283:11: warning: Value stored to 'ret' during its 
initialization is never read <--[clang]
            NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
                     ^~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/auth/auth_util.c:2005:11: warning: Value stored to 'nt_status' 
during its initialization is never read <--[clang]
            NTSTATUS nt_status = NT_STATUS_OK;
                     ^~~~~~~~~   ~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 50ff6c965f23457bfdefa53cd043166fdec899a5
Author: Noel Power <noel.po...@suse.com>
Date:   Fri Sep 6 14:59:51 2019 +0000

    s3/libsmb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/libsmb/dsgetdcname.c:1012:11: warning: Value stored to 'status' 
during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    source3/libsmb/dsgetdcname.c:1099:11: warning: Value stored to 'status' 
during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit eb3ba3eeaa200660c7b48253083bffbe39d41a96
Author: Noel Power <noel.po...@suse.com>
Date:   Fri Sep 6 14:50:37 2019 +0000

    s3/libads: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/libads/ldap_utils.c:52:13: warning: Value stored to 'status' during 
its initialization is never read <--[clang]
            ADS_STATUS status = ADS_SUCCESS;
                       ^~~~~~   ~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 35e0122e7c7f2cdfa0f6ac4f18a8cc7c42edab24
Author: Noel Power <noel.po...@suse.com>
Date:   Fri Sep 6 13:00:05 2019 +0000

    s3/libads: clang: Fix 'Value stored to 'nt_status' is never read'
    
    Fixes:
    
    source3/libads/sasl.c:219:2: warning: Value stored to 'nt_status' is never 
read <--[clang]
            nt_status = NT_STATUS_MORE_PROCESSING_REQUIRED;
            ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit fba666cf2a5c83ee76432f0d0d44e867c62231ba
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Sep 5 15:40:50 2019 +0000

    s3/passed: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/passdb/passdb.c:2502:11: warning: Value stored to 'status' during 
its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit b08ec1903d2ebfdcdb83c0f6e042a6d3b06992c9
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Sep 5 14:48:47 2019 +0000

    s3/rpc_client: clang: 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/rpc_client/util_netlogon.c:71:11: warning: Value stored to 'status' 
during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    
    source3/rpc_client/util_netlogon.c:199:11: warning: Value stored to 
'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit ae2e9ce5c36c9e05f785b3fa7be22074fdc4213d
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Sep 5 14:22:02 2019 +0000

    s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/rpc_client/cli_lsarpc.c:182:11: warning: Value stored to 'status' 
during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 38aafe0d6bba0b7651600edfe2a799dcf7d1ed2d
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Sep 5 13:40:16 2019 +0000

    s3/passdb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/passdb/lookup_sid.c:836:11: warning: Value stored to 'result' 
during its initialization is never read <--[clang]
            NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 299eff4ac906846e8f7f605815792a9d4418f071
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Sep 5 13:36:22 2019 +0000

    s3/passdb: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/passdb/pdb_interface.c:65:34: warning: Value stored to 'entry' 
during its initialization is never read <--[clang]
            struct pdb_init_function_entry *entry = backends;
                                            ^~~~~   ~~~~~~~~
    
    /source3/passdb/pdb_interface.c:140:11: warning: Value stored to 
'nt_status' during its initialization is never read <--[clang]
            NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 2d47067c86303c43f3d7267394ef8a9ce49593d3
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Sep 5 13:34:05 2019 +0000

    s3/passdb: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/passdb/pdb_tdb.c:718:18: warning: Value stored to 'nt_status' 
during its initialization is never read <--[clang]
            NTSTATUS        nt_status = NT_STATUS_UNSUCCESSFUL;
                            ^~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 752f5b63d0c4e0a7cdab74128ea54ade461d18d0
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Aug 15 16:25:27 2019 +0100

    s3/passdb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/passdb/pdb_util.c:41:11: warning: Value stored to 'status' during 
its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit c534b05c8d464940cd4d46c43d6549e86014143b
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Aug 15 15:57:26 2019 +0100

    s4/winbind: clang: Fixes 'Value stored during its initialization is never 
read'
    
    Fixes:
    
    source4/winbind/idmap.c:214:11: warning: Value stored to 'status' during 
its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_NONE_MAPPED;
    
    source4/winbind/idmap.c:397:11: warning: Value stored to 'status' during 
its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_NONE_MAPPED;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 6831b6ba6f52dd865ecf09c575e4862f6dd3424b
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Aug 15 15:32:13 2019 +0100

    s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/rpc_client/cli_pipe.c:397:11: warning: Value stored to 'ret' during 
its initialization is never read <--[clang]
            NTSTATUS ret = NT_STATUS_OK;
                     ^~~   ~~~~~~~~~~~~
    
    source3/rpc_client/cli_pipe.c:1234:11: warning: Value stored to 'ret' 
during its initialization is never read <--[clang]
            NTSTATUS ret = NT_STATUS_OK;
                     ^~~   ~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 368d0cecc0bc859e321335f46b22d4334e092da1
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Aug 15 15:29:03 2019 +0100

    s3/groupdb: clang: 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/groupdb/mapping_tdb.c:460:11: warning: Value stored to 'status' 
during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 6055134330d9e4226deb298c506dc6f792bf5d33
Author: Noel Power <noel.po...@suse.com>
Date:   Thu Aug 15 14:16:52 2019 +0100

    s3/groupdb: clang: Fix 'Value stored during its initialization is never 
read'
    
    Fixes:
    
    ource3/groupdb/mapping.c:648:11: warning: Value stored to 'status' during 
its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.po...@suse.com>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 5550367e46d2ebb2bb0bb35fa51f34ca178d2907
Author: Günther Deschner <g...@samba.org>
Date:   Wed Sep 25 06:53:34 2019 +0200

    s4-torture: remove duplicate NDR_PRINT
    
    Guenther
    
    Signed-off-by: Guenther Deschner <g...@samba.org>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit fd20153e8b095fa9a82a024c3f7bebd809ba132f
Author: Günther Deschner <g...@samba.org>
Date:   Tue Aug 30 19:37:18 2016 +0200

    s4-torture: dump ndr packet in ndr tests with high log level
    
    Guenther
    
    Signed-off-by: Guenther Deschner <g...@samba.org>
    Reviewed-by: Jeremy Allison <j...@samba.org>

commit 86a0e4850e02efc406ae5e1ee7cdc6a61eebef76
Author: Günther Deschner <g...@samba.org>
Date:   Tue Sep 24 23:10:50 2019 +0200

    librpc/ndr: add ndr_print_netlogon_samlogon_response()
    
    Guenther
    
    Signed-off-by: Guenther Deschner <g...@samba.org>
    Reviewed-by: Jeremy Allison <j...@samba.org>

-----------------------------------------------------------------------

Summary of changes:
 lib/talloc/pytalloc_util.c         |  2 +-
 librpc/ndr/ndr_nbt.c               | 13 ++++++
 librpc/ndr/ndr_nbt.h               |  1 +
 source3/auth/auth.c                |  2 +-
 source3/auth/auth_util.c           |  4 +-
 source3/groupdb/mapping.c          |  2 +-
 source3/groupdb/mapping_tdb.c      |  2 +-
 source3/lib/netapi/getdc.c         |  2 +-
 source3/lib/netapi/group.c         |  6 +--
 source3/lib/netapi/user.c          | 10 ++---
 source3/libads/ldap.c              |  8 ++--
 source3/libads/ldap_utils.c        |  2 +-
 source3/libads/sasl.c              |  1 -
 source3/libsmb/cliconnect.c        |  1 -
 source3/libsmb/dsgetdcname.c       |  4 +-
 source3/libsmb/trusts_util.c       |  1 -
 source3/passdb/lookup_sid.c        |  2 +-
 source3/passdb/passdb.c            |  2 +-
 source3/passdb/pdb_interface.c     |  4 +-
 source3/passdb/pdb_ldap.c          |  4 +-
 source3/passdb/pdb_smbpasswd.c     |  6 +--
 source3/passdb/pdb_tdb.c           |  2 +-
 source3/passdb/pdb_util.c          |  2 +-
 source3/rpc_client/cli_lsarpc.c    |  2 +-
 source3/rpc_client/cli_pipe.c      |  4 +-
 source3/rpc_client/cli_winreg.c    |  4 +-
 source3/rpc_client/util_netlogon.c |  4 +-
 source4/torture/ndr/dnsp.c         |  1 -
 source4/torture/ndr/ndr.c          | 81 ++++++++++++++++++++++++++++++++++----
 source4/torture/ndr/ndr.h          | 22 ++++++++++-
 source4/winbind/idmap.c            |  4 +-
 31 files changed, 148 insertions(+), 57 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/talloc/pytalloc_util.c b/lib/talloc/pytalloc_util.c
index c1a41e958d4..c580d46f858 100644
--- a/lib/talloc/pytalloc_util.c
+++ b/lib/talloc/pytalloc_util.c
@@ -230,7 +230,7 @@ static void *_pytalloc_get_checked_type(PyObject *py_obj, 
const char *type_name,
 {
        TALLOC_CTX *mem_ctx;
        void *ptr = NULL;
-       void *type_obj = talloc_check_name(ptr, type_name);
+       void *type_obj;
 
        mem_ctx = _pytalloc_get_mem_ctx(py_obj);
        ptr = _pytalloc_get_ptr(py_obj);
diff --git a/librpc/ndr/ndr_nbt.c b/librpc/ndr/ndr_nbt.c
index 838f947a168..b15dc5c06e5 100644
--- a/librpc/ndr/ndr_nbt.c
+++ b/librpc/ndr/ndr_nbt.c
@@ -449,3 +449,16 @@ _PUBLIC_ enum ndr_err_code 
ndr_pull_netlogon_samlogon_response(struct ndr_pull *
 
        return NDR_ERR_SUCCESS;
 }
+
+_PUBLIC_ void ndr_print_netlogon_samlogon_response(struct ndr_print *ndr, 
const char *name, struct netlogon_samlogon_response *r)
+{
+       ndr_print_struct(ndr, name, "netlogon_samlogon_response");
+       if (r == NULL) { ndr_print_null(ndr); return; }
+       if (r->ntver == NETLOGON_NT_VERSION_1) {
+               ndr_print_NETLOGON_SAM_LOGON_RESPONSE_NT40(ndr, "data.nt4", 
&r->data.nt4);
+       } else if (r->ntver & NETLOGON_NT_VERSION_5EX) {
+               ndr_print_NETLOGON_SAM_LOGON_RESPONSE_EX(ndr, "data.nt5_ex", 
&r->data.nt5_ex);
+       } else if (r->ntver & NETLOGON_NT_VERSION_5) {
+               ndr_print_NETLOGON_SAM_LOGON_RESPONSE(ndr, "data.nt5", 
&r->data.nt5);
+       }
+}
diff --git a/librpc/ndr/ndr_nbt.h b/librpc/ndr/ndr_nbt.h
index edb2bf7687b..7c06301d02b 100644
--- a/librpc/ndr/ndr_nbt.h
+++ b/librpc/ndr/ndr_nbt.h
@@ -37,5 +37,6 @@ enum ndr_err_code 
ndr_pull_NETLOGON_SAM_LOGON_RESPONSE_EX_with_flags(struct ndr_
                                                                     uint32_t 
nt_version_flags);
 enum ndr_err_code ndr_push_netlogon_samlogon_response(struct ndr_push *ndr, 
int ndr_flags, const struct netlogon_samlogon_response *r);
 enum ndr_err_code ndr_pull_netlogon_samlogon_response(struct ndr_pull *ndr, 
int ndr_flags, struct netlogon_samlogon_response *r);
+void ndr_print_netlogon_samlogon_response(struct ndr_print *ndr, const char 
*name, struct netlogon_samlogon_response *r);
 
 #endif /* _LIBRPC_NDR_NDR_NBT_H */
diff --git a/source3/auth/auth.c b/source3/auth/auth.c
index ce2cb0d75bf..3b523c0fa18 100644
--- a/source3/auth/auth.c
+++ b/source3/auth/auth.c
@@ -35,7 +35,7 @@ static struct auth_init_function_entry 
*auth_find_backend_entry(const char *name
 
 NTSTATUS smb_register_auth(int version, const char *name, auth_init_function 
init)
 {
-       struct auth_init_function_entry *entry = auth_backends;
+       struct auth_init_function_entry *entry = NULL;
 
        if (version != AUTH_INTERFACE_VERSION) {
                DEBUG(0,("Can't register auth_method!\n"
diff --git a/source3/auth/auth_util.c b/source3/auth/auth_util.c
index d0be7e6c576..4f9b0a91022 100644
--- a/source3/auth/auth_util.c
+++ b/source3/auth/auth_util.c
@@ -280,7 +280,7 @@ bool make_user_info_for_reply(TALLOC_CTX *mem_ctx,
 
        DATA_BLOB local_lm_blob;
        DATA_BLOB local_nt_blob;
-       NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
+       NTSTATUS ret;
        char *plaintext_password_string;
        /*
         * Not encrypted - do so.
@@ -2002,7 +2002,7 @@ NTSTATUS make_server_info_info3(TALLOC_CTX *mem_ctx,
                                struct auth_serversupplied_info **server_info,
                                const struct netr_SamInfo3 *info3)
 {
-       NTSTATUS nt_status = NT_STATUS_OK;
+       NTSTATUS nt_status;
        char *found_username = NULL;
        const char *nt_domain;
        const char *nt_username;
diff --git a/source3/groupdb/mapping.c b/source3/groupdb/mapping.c
index 1e25c5637dc..ed57955edc9 100644
--- a/source3/groupdb/mapping.c
+++ b/source3/groupdb/mapping.c
@@ -645,7 +645,7 @@ NTSTATUS pdb_default_set_aliasinfo(struct pdb_methods 
*methods,
                                   const struct dom_sid *sid,
                                   struct acct_info *info)
 {
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
        GROUP_MAP *map;
 
        map = talloc_zero(NULL, GROUP_MAP);
diff --git a/source3/groupdb/mapping_tdb.c b/source3/groupdb/mapping_tdb.c
index b7ff724ba05..7f6ae4e65e4 100644
--- a/source3/groupdb/mapping_tdb.c
+++ b/source3/groupdb/mapping_tdb.c
@@ -457,7 +457,7 @@ static NTSTATUS one_alias_membership(const struct dom_sid 
*member,
        char *string_sid;
        TDB_DATA dbuf;
        const char *p;
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
        TALLOC_CTX *frame = talloc_stackframe();
 
        slprintf(key, sizeof(key), "%s%s", MEMBEROF_PREFIX,
diff --git a/source3/lib/netapi/getdc.c b/source3/lib/netapi/getdc.c
index d4633752c78..7e5fab3ff63 100644
--- a/source3/lib/netapi/getdc.c
+++ b/source3/lib/netapi/getdc.c
@@ -170,7 +170,7 @@ WERROR DsGetDcName_r(struct libnetapi_ctx *ctx,
                     struct DsGetDcName *r)
 {
        WERROR werr;
-       NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
+       NTSTATUS status;
        struct dcerpc_binding_handle *b;
 
        werr = libnetapi_get_binding_handle(ctx, r->in.server_name,
diff --git a/source3/lib/netapi/group.c b/source3/lib/netapi/group.c
index f4f2dc26b6a..e0b7458e58c 100644
--- a/source3/lib/netapi/group.c
+++ b/source3/lib/netapi/group.c
@@ -1380,7 +1380,7 @@ WERROR NetGroupEnum_r(struct libnetapi_ctx *ctx,
        uint32_t returned_size = 0;
 
        NTSTATUS result = NT_STATUS_OK;
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
        WERROR werr, tmp_werr;
 
        ZERO_STRUCT(connect_handle);
@@ -1518,7 +1518,7 @@ WERROR NetGroupGetUsers_r(struct libnetapi_ctx *ctx,
        int i;
        uint32_t entries_read = 0;
 
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
        NTSTATUS result = NT_STATUS_OK;
        WERROR werr;
 
@@ -1715,7 +1715,7 @@ WERROR NetGroupSetUsers_r(struct libnetapi_ctx *ctx,
 
        int i, k;
 
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
        NTSTATUS result = NT_STATUS_OK;
        WERROR werr;
 
diff --git a/source3/lib/netapi/user.c b/source3/lib/netapi/user.c
index fc236e55d1f..fb38b233b86 100644
--- a/source3/lib/netapi/user.c
+++ b/source3/lib/netapi/user.c
@@ -1293,7 +1293,7 @@ WERROR NetUserEnum_r(struct libnetapi_ctx *ctx,
        int i;
        uint32_t entries_read = 0;
 
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
        NTSTATUS result = NT_STATUS_OK;
        WERROR werr;
        struct dcerpc_binding_handle *b = NULL;
@@ -1613,7 +1613,7 @@ WERROR NetQueryDisplayInformation_r(struct libnetapi_ctx 
*ctx,
        uint32_t total_size = 0;
        uint32_t returned_size = 0;
 
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
        NTSTATUS result = NT_STATUS_OK;
        WERROR werr;
        WERROR werr_tmp;
@@ -2993,7 +2993,7 @@ WERROR NetUserGetGroups_r(struct libnetapi_ctx *ctx,
        int i;
        uint32_t entries_read = 0;
 
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
        NTSTATUS result = NT_STATUS_OK;
        WERROR werr;
        struct dcerpc_binding_handle *b = NULL;
@@ -3187,7 +3187,7 @@ WERROR NetUserSetGroups_r(struct libnetapi_ctx *ctx,
 
        int i, k;
 
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
        NTSTATUS result = NT_STATUS_OK;
        WERROR werr;
        struct dcerpc_binding_handle *b = NULL;
@@ -3525,7 +3525,7 @@ WERROR NetUserGetLocalGroups_r(struct libnetapi_ctx *ctx,
        int i;
        uint32_t entries_read = 0;
 
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
        NTSTATUS result = NT_STATUS_OK;
        WERROR werr;
        struct dcerpc_binding_handle *b = NULL;
diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
index 2110390b65f..6942106a3c3 100644
--- a/source3/libads/ldap.c
+++ b/source3/libads/ldap.c
@@ -367,7 +367,7 @@ static NTSTATUS resolve_and_ping_netbios(ADS_STRUCT *ads,
 {
        int count, i;
        struct ip_service *ip_list;
-       NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
+       NTSTATUS status;
 
        DEBUG(6, ("resolve_and_ping_netbios: (cldap) looking for domain '%s'\n",
                  domain));
@@ -414,7 +414,7 @@ static NTSTATUS resolve_and_ping_dns(ADS_STRUCT *ads, const 
char *sitename,
 {
        int count;
        struct ip_service *ip_list = NULL;
-       NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
+       NTSTATUS status;
 
        DEBUG(6, ("resolve_and_ping_dns: (cldap) looking for realm '%s'\n",
                  realm));
@@ -1780,7 +1780,7 @@ uint32_t ads_get_kvno(ADS_STRUCT *ads, const char 
*account_name)
        char *filter;
        const char *attrs[] = {"msDS-KeyVersionNumber", NULL};
        char *dn_string = NULL;
-       ADS_STATUS ret = ADS_ERROR(LDAP_SUCCESS);
+       ADS_STATUS ret;
 
        DEBUG(5,("ads_get_kvno: Searching for account %s\n", account_name));
        if (asprintf(&filter, "(samAccountName=%s)", account_name) == -1) {
@@ -1859,7 +1859,7 @@ ADS_STATUS ads_clear_service_principal_names(ADS_STRUCT 
*ads, const char *machin
        LDAPMessage *res = NULL;
        ADS_MODLIST mods;
        const char *servicePrincipalName[1] = {NULL};
-       ADS_STATUS ret = ADS_ERROR(LDAP_SUCCESS);
+       ADS_STATUS ret;
        char *dn_string = NULL;
 
        ret = ads_find_machine_acct(ads, &res, machine_name);
diff --git a/source3/libads/ldap_utils.c b/source3/libads/ldap_utils.c
index 0c37b06500c..c9039684bf0 100644
--- a/source3/libads/ldap_utils.c
+++ b/source3/libads/ldap_utils.c
@@ -49,7 +49,7 @@ static ADS_STATUS ads_do_search_retry_internal(ADS_STRUCT 
*ads, const char *bind
                                               const char **attrs, void *args,
                                               LDAPMessage **res)
 {
-       ADS_STATUS status = ADS_SUCCESS;
+       ADS_STATUS status;
        int count = 3;
        char *bp;
 
diff --git a/source3/libads/sasl.c b/source3/libads/sasl.c
index 010a2538206..613645f8f54 100644
--- a/source3/libads/sasl.c
+++ b/source3/libads/sasl.c
@@ -216,7 +216,6 @@ static ADS_STATUS ads_sasl_spnego_gensec_bind(ADS_STRUCT 
*ads,
        }
 
        rc = LDAP_SASL_BIND_IN_PROGRESS;
-       nt_status = NT_STATUS_MORE_PROCESSING_REQUIRED;
        if (use_spnego_principal) {
                blob_in = data_blob_dup_talloc(talloc_tos(), server_blob);
                if (blob_in.length == 0) {
diff --git a/source3/libsmb/cliconnect.c b/source3/libsmb/cliconnect.c
index 472cdd4efa2..055e1c57639 100644
--- a/source3/libsmb/cliconnect.c
+++ b/source3/libsmb/cliconnect.c
@@ -677,7 +677,6 @@ static void cli_session_setup_guest_done(struct tevent_req 
*subreq)
                tevent_req_nterror(req, status);
                return;
        }
-       p += ret;
 
        tevent_req_done(req);
 }
diff --git a/source3/libsmb/dsgetdcname.c b/source3/libsmb/dsgetdcname.c
index 08477065f34..06119471c2b 100644
--- a/source3/libsmb/dsgetdcname.c
+++ b/source3/libsmb/dsgetdcname.c
@@ -1009,7 +1009,7 @@ static NTSTATUS dsgetdcname_rediscover(TALLOC_CTX 
*mem_ctx,
                                       const char *site_name,
                                       struct netr_DsRGetDCNameInfo **info)
 {
-       NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
+       NTSTATUS status;
        struct ip_service_name *dclist = NULL;
        int num_dcs;
 
@@ -1096,7 +1096,7 @@ static NTSTATUS dsgetdcname_internal(TALLOC_CTX *mem_ctx,
                     uint32_t flags,
                     struct netr_DsRGetDCNameInfo **info)
 {
-       NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
+       NTSTATUS status;
        struct netr_DsRGetDCNameInfo *myinfo = NULL;
        bool first = true;
        struct netr_DsRGetDCNameInfo *first_info = NULL;
diff --git a/source3/libsmb/trusts_util.c b/source3/libsmb/trusts_util.c
index 0f0541a26b9..55e3c74494a 100644
--- a/source3/libsmb/trusts_util.c
+++ b/source3/libsmb/trusts_util.c
@@ -599,7 +599,6 @@ NTSTATUS trust_pw_change(struct netlogon_creds_cli_context 
*context,
         * Now we verify the new password.
         */
        idx = 0;
-       idx_current = idx;
        nt_hashes[idx++] = current_nt_hash;
        num_nt_hashes = idx;
        status = netlogon_creds_cli_lck_auth(context, b,
diff --git a/source3/passdb/lookup_sid.c b/source3/passdb/lookup_sid.c
index c31a9e48739..82c47b3145b 100644
--- a/source3/passdb/lookup_sid.c
+++ b/source3/passdb/lookup_sid.c
@@ -833,7 +833,7 @@ NTSTATUS lookup_sids(TALLOC_CTX *mem_ctx, int num_sids,
                     struct lsa_name_info **ret_names)
 {
        TALLOC_CTX *tmp_ctx;
-       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+       NTSTATUS result;
        struct lsa_name_info *name_infos;
        struct lsa_dom_info *dom_infos = NULL;
 
diff --git a/source3/passdb/passdb.c b/source3/passdb/passdb.c
index 401a11135cd..8ed1bafcea3 100644
--- a/source3/passdb/passdb.c
+++ b/source3/passdb/passdb.c
@@ -2499,7 +2499,7 @@ NTSTATUS pdb_get_trust_credentials(const char 
*netbios_domain,
                                   struct cli_credentials **_creds)
 {
        TALLOC_CTX *frame = talloc_stackframe();
-       NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
+       NTSTATUS status;
        struct loadparm_context *lp_ctx;
        enum netr_SchannelType channel;
        time_t last_set_time;
diff --git a/source3/passdb/pdb_interface.c b/source3/passdb/pdb_interface.c
index d42d5e52932..556839ae9d1 100644
--- a/source3/passdb/pdb_interface.c
+++ b/source3/passdb/pdb_interface.c
@@ -62,7 +62,7 @@ static bool lookup_global_sam_rid(TALLOC_CTX *mem_ctx, 
uint32_t rid,
 
 NTSTATUS smb_register_passdb(int version, const char *name, pdb_init_function 
init) 
 {
-       struct pdb_init_function_entry *entry = backends;
+       struct pdb_init_function_entry *entry = NULL;
 
        if(version != PASSDB_INTERFACE_VERSION) {
                DEBUG(0,("Can't register passdb backend!\n"
@@ -137,7 +137,7 @@ NTSTATUS make_pdb_method_name(struct pdb_methods **methods, 
const char *selected
        char *module_name = smb_xstrdup(selected);
        char *module_location = NULL, *p;
        struct pdb_init_function_entry *entry;
-       NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
+       NTSTATUS nt_status;
 
        lazy_initialize_passdb();
 
diff --git a/source3/passdb/pdb_ldap.c b/source3/passdb/pdb_ldap.c
index 3dbc8f9f07a..aefd770ad31 100644
--- a/source3/passdb/pdb_ldap.c
+++ b/source3/passdb/pdb_ldap.c
@@ -491,7 +491,6 @@ static bool init_sam_from_ldap(struct ldapsam_privates 
*ldap_state,
        uint8_t         smblmpwd[LM_HASH_LEN],
                        smbntpwd[NT_HASH_LEN];
        bool            use_samba_attrs = True;
-       uint32_t                acct_ctrl = 0;
        uint16_t                logon_divs;
        uint16_t                bad_password_count = 0,
                        logon_count = 0;
@@ -911,6 +910,7 @@ static bool init_sam_from_ldap(struct ldapsam_privates 
*ldap_state,
                                LDAP_ATTR_ACB_INFO),
                        ctx);
        if (temp) {
+               uint32_t acct_ctrl = 0;
                acct_ctrl = pdb_decode_acct_ctrl(temp);
 
                if (acct_ctrl == 0) {
@@ -918,8 +918,6 @@ static bool init_sam_from_ldap(struct ldapsam_privates 
*ldap_state,
                }
 
                pdb_set_acct_ctrl(sampass, acct_ctrl, PDB_SET);
-       } else {
-               acct_ctrl |= ACB_NORMAL;
        }
 
        pdb_set_hours_len(sampass, hours_len, PDB_SET);
diff --git a/source3/passdb/pdb_smbpasswd.c b/source3/passdb/pdb_smbpasswd.c
index a9def1260d4..bed3cea744c 100644
--- a/source3/passdb/pdb_smbpasswd.c
+++ b/source3/passdb/pdb_smbpasswd.c
@@ -367,7 +367,6 @@ static struct smb_passwd *getsmbfilepwent(struct 
smbpasswd_privates *smbpasswd_s
        unsigned char *smbpwd = smbpasswd_state->smbpwd;
        unsigned char *smbntpwd = smbpasswd_state->smbntpwd;
        char linebuf[256];
-       int c;
        unsigned char *p;
        long uidval;
        size_t linebuf_len;
@@ -402,8 +401,8 @@ static struct smb_passwd *getsmbfilepwent(struct 
smbpasswd_privates *smbpasswd_s
                }
 
                if (linebuf[linebuf_len - 1] != '\n') {
-                       c = '\0';
                        while (!ferror(fp) && !feof(fp)) {
+                               int c;
                                c = fgetc(fp);
                                if (c == '\n') {
                                        break;
@@ -740,7 +739,6 @@ static bool mod_smbfilepwd_entry(struct smbpasswd_privates 
*smbpasswd_state, con
 #define LINEBUF_SIZE 255
        char linebuf[LINEBUF_SIZE + 1];
        char readbuf[1024];
-       int c;
        char ascii_p16[FSTRING_LEN + 20];
        fstring encode_bits;
        unsigned char *p = NULL;
@@ -806,8 +804,8 @@ static bool mod_smbfilepwd_entry(struct smbpasswd_privates 
*smbpasswd_state, con
                 */
                linebuf_len = strlen(linebuf);
                if (linebuf[linebuf_len - 1] != '\n') {
-                       c = '\0';
                        while (!ferror(fp) && !feof(fp)) {
+                               int c;
                                c = fgetc(fp);
                                if (c == '\n') {
                                        break;
diff --git a/source3/passdb/pdb_tdb.c b/source3/passdb/pdb_tdb.c
index 0c97e70bad4..7488d99a94e 100644
--- a/source3/passdb/pdb_tdb.c
+++ b/source3/passdb/pdb_tdb.c
@@ -715,7 +715,7 @@ static bool tdb_delete_samacct_only( struct samu *sam_pass )
 static NTSTATUS tdbsam_delete_sam_account(struct pdb_methods *my_methods,
                                          struct samu *sam_pass)
 {
-       NTSTATUS        nt_status = NT_STATUS_UNSUCCESSFUL;
+       NTSTATUS        nt_status;
        fstring         keystr;
        uint32_t        rid;
        fstring         name;
diff --git a/source3/passdb/pdb_util.c b/source3/passdb/pdb_util.c
index 780c03fdc8d..b732acacd85 100644
--- a/source3/passdb/pdb_util.c
+++ b/source3/passdb/pdb_util.c
@@ -38,7 +38,7 @@
 static NTSTATUS add_sid_to_builtin(const struct dom_sid *builtin_sid,
                                   const struct dom_sid *dom_sid)
 {
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
 
        if (!dom_sid || !builtin_sid) {
                return NT_STATUS_INVALID_PARAMETER;
diff --git a/source3/rpc_client/cli_lsarpc.c b/source3/rpc_client/cli_lsarpc.c
index a093ee2572c..8f064f64a6c 100644
--- a/source3/rpc_client/cli_lsarpc.c
+++ b/source3/rpc_client/cli_lsarpc.c
@@ -179,7 +179,7 @@ static NTSTATUS dcerpc_lsa_lookup_sids_noalloc(struct 
dcerpc_binding_handle *h,
                                               bool use_lookupsids3,
                                               NTSTATUS *presult)
 {
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
        struct lsa_SidArray sid_array;
        struct lsa_RefDomainList *ref_domains = NULL;
diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c
index 81b6bfb75bf..78197d99f9c 100644
--- a/source3/rpc_client/cli_pipe.c
+++ b/source3/rpc_client/cli_pipe.c
@@ -394,7 +394,7 @@ static NTSTATUS cli_pipe_validate_current_pdu(TALLOC_CTX 
*mem_ctx,
 {
        const struct dcerpc_response *r = NULL;
        DATA_BLOB tmp_stub = data_blob_null;
-       NTSTATUS ret = NT_STATUS_OK;
+       NTSTATUS ret;
 
        /*
         * Point the return values at the real data including the RPC
@@ -1231,7 +1231,7 @@ static NTSTATUS create_rpc_bind_req(TALLOC_CTX *mem_ctx,
 {
        DATA_BLOB auth_token = data_blob_null;
        DATA_BLOB auth_info = data_blob_null;
-       NTSTATUS ret = NT_STATUS_OK;
+       NTSTATUS ret;
 
        switch (auth->auth_type) {
        case DCERPC_AUTH_TYPE_NONE:
diff --git a/source3/rpc_client/cli_winreg.c b/source3/rpc_client/cli_winreg.c
index 37f349e8694..a51be3682b4 100644
--- a/source3/rpc_client/cli_winreg.c
+++ b/source3/rpc_client/cli_winreg.c
@@ -725,7 +725,7 @@ NTSTATUS dcerpc_winreg_enumvals(TALLOC_CTX *mem_ctx,
 
 
        WERROR result = WERR_OK;
-       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS status;
 
        tmp_ctx = talloc_stackframe();


-- 
Samba Shared Repository

Reply via email to