The branch, master has been updated
via 213501163c0 share_mode_lock.c: initialize out param
from a89efdfe823 libgpo: only install group policy admx files when
building as DC
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 213501163c0cd139b711e8b62bd21d4d7011045b
Author: Isaac Boukris <[email protected]>
Date: Mon Jun 29 10:42:09 2020 +0200
share_mode_lock.c: initialize out param
detected by covscan:
source3/locking/share_mode_lock.c:1563:6: warning: Branch condition
evaluates to a garbage value
Signed-off-by: Isaac Boukris <[email protected]>
Reviewed-by: David Mulder <[email protected]>
Autobuild-User(master): Isaac Boukris <[email protected]>
Autobuild-Date(master): Tue Jun 30 09:42:33 UTC 2020 on sn-devel-184
-----------------------------------------------------------------------
Summary of changes:
source3/locking/share_mode_lock.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/locking/share_mode_lock.c
b/source3/locking/share_mode_lock.c
index adfa917df31..a93141304b2 100644
--- a/source3/locking/share_mode_lock.c
+++ b/source3/locking/share_mode_lock.c
@@ -1765,8 +1765,9 @@ static size_t share_mode_entry_find(
{
ssize_t left, right, middle;
+ *match = false;
+
if (num_share_modes == 0) {
- *match = false;
return 0;
}
@@ -1790,7 +1791,7 @@ static size_t share_mode_entry_find(
ok = share_mode_entry_get(middle_ptr, e);
if (!ok) {
DBG_DEBUG("share_mode_entry_get failed\n");
- return false;
+ return 0;
}
cmp = share_mode_entry_cmp(
@@ -1807,7 +1808,6 @@ static size_t share_mode_entry_find(
}
}
- *match = false;
return left;
}
--
Samba Shared Repository
