The branch, master has been updated
via c2fcd83ed7b s4:libnet:py_net - free event context in dealloc fn
from ca07dc775cb Revert "lookup_name: allow lookup for own realm"
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit c2fcd83ed7b5cf54b2c5de296a4126ea4e9e155e
Author: Andrew Walker <awal...@ixsystems.com>
Date: Mon Nov 2 16:42:29 2020 -0500
s4:libnet:py_net - free event context in dealloc fn
Creation of a new Net() object initializes an event context under
a NULL talloc context and then creates a new talloc context as a
child of the event context. The deallocation function for the
net object only frees the child and not the parent. This leaks an
fd for the tevent context and associated memory.
Signed-off-by: Andrew Walker <awal...@ixsystems.com>
Reviewed-by: Jeremy Allison <j...@samba.org>
Reviewed-by: Gary Lockyer <g...@catalyst.net.nz>
Autobuild-User(master): Jeremy Allison <j...@samba.org>
Autobuild-Date(master): Fri Nov 6 04:58:31 UTC 2020 on sn-devel-184
-----------------------------------------------------------------------
Summary of changes:
source4/libnet/py_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/source4/libnet/py_net.c b/source4/libnet/py_net.c
index 25a25b0cfd1..df9280d8c18 100644
--- a/source4/libnet/py_net.c
+++ b/source4/libnet/py_net.c
@@ -843,7 +843,7 @@ static PyMethodDef net_obj_methods[] = {
static void py_net_dealloc(py_net_Object *self)
{
- talloc_free(self->mem_ctx);
+ talloc_free(self->ev);
PyObject_Del(self);
}
--
Samba Shared Repository
