The branch, master has been updated via b948aeac539 hdb: Initialise HDB structure from 221569a14c8 tests/krb5: Allow PADATA-ENCRYPTED-CHALLENGE to be missing for skew errors
https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit b948aeac5398693e0c8c70cbff531965ed7ecd23 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Dec 8 16:42:32 2021 +1300 hdb: Initialise HDB structure Additional fields may be added to this structure without us explicitly initialising them. This could cause Heimdal to crash upon reading garbage data, so we should zero-initialise the structure. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> Autobuild-User(master): Andrew Bartlett <abart...@samba.org> Autobuild-Date(master): Thu Dec 9 02:47:27 UTC 2021 on sn-devel-184 ----------------------------------------------------------------------- Summary of changes: source4/kdc/hdb-samba4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Changeset truncated at 500 lines: diff --git a/source4/kdc/hdb-samba4.c b/source4/kdc/hdb-samba4.c index f0939193ad7..92bc5ff28a6 100644 --- a/source4/kdc/hdb-samba4.c +++ b/source4/kdc/hdb-samba4.c @@ -530,7 +530,7 @@ NTSTATUS hdb_samba4_create_kdc(struct samba_kdc_base_context *base_ctx, return NT_STATUS_ERROR_DS_INCOMPATIBLE_VERSION; } - *db = talloc(base_ctx, HDB); + *db = talloc_zero(base_ctx, HDB); if (!*db) { krb5_set_error_message(context, ENOMEM, "malloc: out of memory"); return NT_STATUS_NO_MEMORY; -- Samba Shared Repository