The branch, master has been updated via 70b9977a46e s3:libsmb: Fix errno for failed authentication in SMBC_server_internal() via fb13c7c94f1 vfs: Getting exact attribute value during gpfs_stat_x calls from 68d181ee676 s3:libads: Fix creating local krb5.conf
https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit 70b9977a46e5242174b4461a7f49d5f640c1db62 Author: Elia Geretto <elia.f.gere...@gmail.com> Date: Fri Mar 11 19:32:30 2022 +0100 s3:libsmb: Fix errno for failed authentication in SMBC_server_internal() In SMBC_server_internal(), when authentication fails, the errno value is currently hard-coded to EPERM, while it should be EACCES instead. Use the NT_STATUS map to set the appropriate value. This bug was found because it breaks listing printers protected by authentication in GNOME Control Panel. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14983 Signed-off-by: Elia Geretto <elia.f.gere...@gmail.com> Reviewed-by: Jeremy Allison <j...@samba.org> Reviewed-by: Volker Lendecke <v...@samba.org> Autobuild-User(master): Jeremy Allison <j...@samba.org> Autobuild-Date(master): Wed Mar 16 19:44:18 UTC 2022 on sn-devel-184 commit fb13c7c94f17283615953ce3bf690722c6918e9f Author: Archana <archana.chidirala.chidir...@ibm.com> Date: Mon Mar 14 15:16:17 2022 +0530 vfs: Getting exact attribute value during gpfs_stat_x calls To properly update the filesize on all cluster nodes simultaneously Signed-off-by: Archana Chidirala <archana.chidirala.chidir...@ibm.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Jeremy Allison <j...@samba.org> ----------------------------------------------------------------------- Summary of changes: source3/libsmb/libsmb_server.c | 2 +- source3/modules/vfs_gpfs.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/libsmb/libsmb_server.c b/source3/libsmb/libsmb_server.c index b92477c88fe..09d27868c0e 100644 --- a/source3/libsmb/libsmb_server.c +++ b/source3/libsmb/libsmb_server.c @@ -572,7 +572,7 @@ SMBC_server_internal(TALLOC_CTX *ctx, !NT_STATUS_IS_OK(cli_session_setup_anon(c))) { cli_shutdown(c); - errno = EPERM; + errno = map_errno_from_nt_status(status); return NULL; } } diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c index 1444d44bbb9..004c74cd43a 100644 --- a/source3/modules/vfs_gpfs.c +++ b/source3/modules/vfs_gpfs.c @@ -1482,7 +1482,7 @@ static NTSTATUS vfs_gpfs_fget_dos_attributes(struct vfs_handle_struct *handle, char buf[PATH_MAX]; const char *p = NULL; struct gpfs_iattr64 iattr = { }; - unsigned int litemask; + unsigned int litemask = GPFS_SLITE_EXACT_BITS; struct timespec ts; uint64_t file_id; NTSTATUS status; @@ -1988,7 +1988,7 @@ static int vfs_gpfs_check_pathref_fstat_x(struct gpfs_config_data *config, struct connection_struct *conn) { struct gpfs_iattr64 iattr = {0}; - unsigned int litemask; + unsigned int litemask = GPFS_SLITE_EXACT_BITS; int saved_errno; int fd; int ret; -- Samba Shared Repository