The branch, master has been updated
via 1ec54347aca smbd: Fix CID 1665417, UNUSED_VALUE in
openat_pathref_fsp_dot()
from d4b448c305f ctdb: Fix redefinitoin of pmdaResult
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 1ec54347acac241f900b52c16c2dcba04164e898
Author: Anoop C S <anoo...@samba.org>
Date: Thu Sep 11 11:41:25 2025 +0530
smbd: Fix CID 1665417, UNUSED_VALUE in openat_pathref_fsp_dot()
Rearrange how the open flags are defined so as to make Coverity happy
about it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15897
Signed-off-by: Anoop C S <anoo...@samba.org>
Reviewed-by: Volker Lendecke <v...@samba.org>
Autobuild-User(master): Anoop C S <anoo...@samba.org>
Autobuild-Date(master): Mon Sep 15 15:44:38 UTC 2025 on atb-devel-224
-----------------------------------------------------------------------
Summary of changes:
source3/smbd/files.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/smbd/files.c b/source3/smbd/files.c
index 3cf1e78a704..334810e45f9 100644
--- a/source3/smbd/files.c
+++ b/source3/smbd/files.c
@@ -1672,9 +1672,7 @@ NTSTATUS openat_pathref_fsp_dot(TALLOC_CTX *mem_ctx,
struct connection_struct *conn = dirfsp->conn;
struct files_struct *fsp = NULL;
struct smb_filename *full_fname = NULL;
- struct vfs_open_how how = {
- .flags = O_RDONLY | O_NONBLOCK | O_NOFOLLOW,
- };
+ struct vfs_open_how how = { .flags = O_NOFOLLOW, };
struct smb_filename *dot = NULL;
NTSTATUS status;
int fd;
@@ -1684,7 +1682,9 @@ NTSTATUS openat_pathref_fsp_dot(TALLOC_CTX *mem_ctx,
#endif
#ifdef O_PATH
- how.flags = O_PATH;
+ how.flags |= O_PATH;
+#else
+ how.flags |= (O_RDONLY | O_NONBLOCK);
#endif
dot = synthetic_smb_fname(mem_ctx, ".", NULL, NULL, 0, flags);
--
Samba Shared Repository
