The branch, master has been updated
via 75cb02dfcb3 s4:torture:vfs:fruit fix Clang compilation issue
via 6af2e180ce1 s4:kdc:db-glue-tests Fix CID 1666664
from 9f45eae2928 smbd: only increment lease epoch if a lease was granted
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 75cb02dfcb3f260562c7d48140d99b31856be239
Author: Gary Lockyer <[email protected]>
Date: Mon Oct 13 09:46:16 2025 +1300
s4:torture:vfs:fruit fix Clang compilation issue
Fix:
[4176/4995] Compiling source4/torture/vfs/fruit.c
../../source4/torture/vfs/fruit.c:7900:2: error: variable 'h' is used
uninitialized whenever 'if' condition is true
[-Werror,-Wsometimes-uninitialized]
7900 | CHECK_STATUS(status, NT_STATUS_OK);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Gary Lockyer <[email protected]>
Reviewed-by: Martin Schwenke <[email protected]>
Autobuild-User(master): Martin Schwenke <[email protected]>
Autobuild-Date(master): Mon Oct 13 04:42:16 UTC 2025 on atb-devel-224
commit 6af2e180ce1c1e599d60fc6bfd5086216e92b040
Author: Gary Lockyer <[email protected]>
Date: Mon Oct 13 09:44:49 2025 +1300
s4:kdc:db-glue-tests Fix CID 1666664
Fix Coverity issue CID 1666664
115 char* ts = ldb_timestring(msg, created);
>>> CID 1666664: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "NULL" "ts" when calling
>>> "ldb_msg_add_string".
116 ldb_msg_add_string(msg, "whenCreated", ts);
Signed-off-by: Gary Lockyer <[email protected]>
Reviewed-by: Martin Schwenke <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
source4/kdc/tests/db-glue-test.c | 1 +
source4/torture/vfs/fruit.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/source4/kdc/tests/db-glue-test.c b/source4/kdc/tests/db-glue-test.c
index d98b143779d..2ff528b129c 100644
--- a/source4/kdc/tests/db-glue-test.c
+++ b/source4/kdc/tests/db-glue-test.c
@@ -113,6 +113,7 @@ static void add_whenCreated(struct ldb_message *msg,
time_t created)
{
char* ts = ldb_timestring(msg, created);
+ assert_non_null(ts);
ldb_msg_add_string(msg, "whenCreated", ts);
}
diff --git a/source4/torture/vfs/fruit.c b/source4/torture/vfs/fruit.c
index a6f86cd5edf..71e7eedfdbd 100644
--- a/source4/torture/vfs/fruit.c
+++ b/source4/torture/vfs/fruit.c
@@ -7847,7 +7847,7 @@ static bool test_readonly_exclusive_lock(struct
torture_context *tctx,
{
NTSTATUS status;
bool ret = true;
- struct smb2_handle h;
+ struct smb2_handle h = {};
struct smb2_create create;
struct smb2_lock lock;
struct smb2_lock_element lock_element;
--
Samba Shared Repository
