The branch, master has been updated
via 4468d8274c6 s3:utils: Fix misleading recursive flag in smbget error
message
from c43d52e57bd vfs: Simplify xattr_tdb_getxattrat_send()
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 4468d8274c6df1c5d6d6430b6ea768c40048fe8a
Author: DESKTOP-73571CJ\User <[email protected]>
Date: Wed Feb 11 16:04:33 2026 +0800
s3:utils: Fix misleading recursive flag in smbget error message
The error message in smbget incorrectly instructs users to use "-R" for
recursive downloads.
In recent Samba versions, the "-R" flag was repurposed for
"--name-resolve" to align with other tools. The correct flag for
recursion is now "--recursive". This mismatch causes confusion as using
"-R" triggers a parameter parsing error rather than enabling recursion.
This patch updates the error string to correctly suggest "--recursive"
instead of "-R".
RN: smbget: Fix error message suggesting wrong flag for recursion.
Signed-off-by: Hugo Chia [email protected]
Reviewed-by: Anoop C S <[email protected]>
Reviewed-by: John Mulligan <[email protected]>
Autobuild-User(master): Anoop C S <[email protected]>
Autobuild-Date(master): Mon Feb 16 15:37:04 UTC 2026 on atb-devel-224
-----------------------------------------------------------------------
Summary of changes:
source3/utils/smbget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/source3/utils/smbget.c b/source3/utils/smbget.c
index d9744405bed..2ec5cf654ed 100644
--- a/source3/utils/smbget.c
+++ b/source3/utils/smbget.c
@@ -390,7 +390,7 @@ static bool smb_download_file(const char *base, const char
*name,
case EISDIR:
if (!recursive) {
fprintf(stderr,
- "%s is a directory. Specify -R "
+ "%s is a directory. Specify --recursive
"
"to download recursively\n",
path);
return false;
--
Samba Shared Repository
