Mike Gerdts wrote: > winbindd: Fixed up formatting to get rid of 4-space tabs that existed > before. Builds off of today's SAMBA_2_2 branch.
While they are pretty similar ATM, I need patches to be against and tested with HEAD. I don't apply stuff to 2.2. Other than that, I have some other comments: It would be worthwile setting up soem state for the plugin, where it can store things like connection pointers etc, talloc etc. Make the init function's return include a void * that you always pass back to it. Also add a 'shutdown' function so that the plugin can clean up before we shutdown winbind or we reload the plugin. How does that sound? Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
