[EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] wrote: > On Tue, Aug 27, 2002 at 06:49:27AM +1000, Andrew Bartlett wrote: > > [EMAIL PROTECTED] wrote: > > > > > > On Mon, Aug 26, 2002 at 11:20:00AM -0400, [EMAIL PROTECTED] wrote: > > > > I read that you are planning a 2.2.6 release of Samba. Would it > > > > be possible for you to apply the following short patches to > > > > samba/source/profile/profile.c and samba/source/utils/status.c > > > > in the 2.2 branch ?? > > > > > > Ok - will do - watch for checkin message. > > > The only problem I have with this patch is that it makes smbstatus > > depend on --with-profile again. The idea was that you should not have > > to recompile smbstatus to attach to a --with-profile smbd. > > > > I had asked jelmer to look into a HAVE_SHMEM test, but I'm not sure how > > far he got (he did a heck of a lot during that plugfest...).
I agree that probing for shmem() would be a cleaner fix. Or stay with the POSIX mmap function (which we have) instead of shmem, which is System V. I assumed that you had a good reason for using shmat instead of mmap. > > Also, I think this patch picks up Solaris sys/syslog.h, but not Linux's > > syslog.h. (Broken in HEAD too). If I did this it was inadvertent. Hmm. All I did was wrap an existing #include <syslog.h> within WITH_SYSLOG. Oh oh, I get it. I should have added a configure test for syslog.h and used HAVE_SYSLOG_H. Shall I supply a patch or it is obvious? > For the 2.2.6 release I'm happy with it as it increases the portability > of the code. And making the assumption that smbstatus was compiled with > smbd is not too onerous (IMHO). > > Jeremy. Many thanks. PG
