On Thu, 2002-11-21 at 07:46, Clive Elsum wrote: > > Hi, > > I have not had any feedback on the replacement module for timegm within > /lib/replace.c. This fix allows a correct Solaris build, without it Clock Skew > errors occur unless the machine is dropped back to GMT. Is there any chance of > this being implemented?
I was hoping that somebody else would give a reaction :-) I'll try to get to it, Andrew Bartlett > Thanks in advance > > Clive > > Original message attached > > Delivered-To: [EMAIL PROTECTED] > From: [EMAIL PROTECTED] > To: [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED], [EMAIL PROTECTED] > Subject: FIX to RE: Cannot get net ads join to work under Solaris 8 > MIME-Version: 1.0 > X-BeenThere: [EMAIL PROTECTED] > X-Mailman-Version: 2.0.13 > List-Help: <mailto:[EMAIL PROTECTED]?subject=help> > List-Post: <mailto:[EMAIL PROTECTED]> > List-Subscribe: <http://lists.samba.org/mailman/listinfo/samba-technical>, > <mailto:[EMAIL PROTECTED]?subject=subscribe> > List-Id: Discussions on Samba internals. For general questions please subscribe > to the list [EMAIL PROTECTED] <samba-technical.lists.samba.org> > List-Unsubscribe: <http://lists.samba.org/mailman/listinfo/samba-technical>, > <mailto:[EMAIL PROTECTED]?subject=unsubscribe> > List-Archive: <http://lists.samba.org/pipermail/samba-technical/> > X-Original-Date: Sun, 17 Nov 2002 19:33:23 +1100 > Date: Sun, 17 Nov 2002 19:33:23 +1100 > > Andrew, > > Another suggestion which appears to work without a kludge is a very minor > mod to the code originally contributed by Roger Beeman <[EMAIL PROTECTED]>, > with the help of Mark Baushke <[EMAIL PROTECTED]> and the rest of the Gurus at > CISCO. Further improved by Roger with assistance from Edward J. Sabol based > on input by Jamie Zawinski. > Setting this as a timegm replacement within lib/replace.c overcomes the need > to reset TIMEZONE. > > > time_t timegm(struct tm *t) > { > time_t tl, tb; > struct tm *tg; > > tl = mktime (t); > if (tl == -1) > { > t->tm_hour--; > tl = mktime (t); > if (tl == -1) > return -1; /* can't deal with output from strptime */ > tl += 3600; > } > tg = gmtime (&tl); > tg->tm_isdst = 0; > tb = mktime (tg); > if (tb == -1) > { > tg->tm_hour--; > tb = mktime (tg); > if (tb == -1) > return -1; /* can't deal with output from gmtime */ > tb += 3600; > } > return (tl - (tb - tl)); > > > > --------------------------------------------------------------------- > Clive Elsum BAppSc, RHCE > Systems Engineer - Information Technology Group > CSIRO Atmospheric Research > PMB 1, Aspendale, Victoria, Australia 3195 > Phone : (+61 3) 9239 4509 > Fax: (+61 3) 9239 4444 > E-mail [EMAIL PROTECTED] > --------------------------------------------------------------------- > -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
signature.asc
Description: This is a digitally signed message part
