On Thu, Jan 16, 2003 at 01:07:34AM -0500, Michael Bennett wrote:
>
> So... comments? Does the patch Do The Right Thing? Think this patch or
> something similar could get merged sometime? :)
I remember looking at this patch. The problem is it does something
like :
#ifdef *BSD..
new code...
#else
original code.
#endif
We don't accept patches that are specific to a particular OS
in this way anymore (unless there's a really good reason). The
correct way to do this is to add a feature test in configure.in
that checks if this function works correctly, that way it gets
fixed for all platforms it is broken on.
A patch like that would get accepted immediately. Without it,
we have to write the feature test.
Jeremy.
