On Wed, Jan 29, 2003 at 04:44:06PM +1100, Tim Potter wrote:
> Er, should I be worried about this warning?
>
> libsmb/clireadwrite.c: In function `cli_issue_read':
> libsmb/clireadwrite.c:54: warning: right shift count >= width of type
> libsmb/clireadwrite.c: In function `cli_issue_write':
> libsmb/clireadwrite.c:301: warning: right shift count >= width of type
>
> It's presumably complaining about the size of offset being 32 bits.
>
> static BOOL cli_issue_read(struct cli_state *cli, int fnum,
> off_t offset, size_t size, int i)
> {
> [...]
>
> if (bigoffset)
> SIVAL(cli->outbuf,smb_vwv10,(offset>>32) & 0xffffffff);
Hmmm. It should really be using an SMB_OFF_T which will be
64-bits on a 64-bit machine.
Jeremy.
