On Tue, 2003-02-18 at 11:01, Martin Pool wrote: > StrCaseCmp (and strequal) in HEAD has the interesting side-effect that it only > compares the first PSTRING_LEN (1024) bytes of the strings. > > I suppose comparing strings longer than that is probably a bit > unlikely, but it still seems kind of dangerous. > > Would it be OK to change it to use dynamic allocation?
I think so. Possibly only for long strings? But then that is probably micro-optimization. Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
signature.asc
Description: This is a digitally signed message part
