-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, 4 Mar 2003 [EMAIL PROTECTED] wrote:
> > Date: Tue Mar 4 09:33:34 2003 > Author: abartlet > > Update of /data/cvs/samba/source/printing > In directory dp.samba.org:/tmp/cvs-serv25296/printing > > Modified Files: > nt_printing.c > Log Message: > > Fix another 'off by one' bug with safe_strcpy(). It is unclear if the > intent was to limit the string to 31 or 32 characters (excluding the > null term), so I've assumed for now that 32 is fine, as this matches > current behaviour (well, current behaviour would crash, but anyway...) > > Jerry: Can you look at this for me? The devicename is truncated at 32 characters (including NULL). See spool_io_devmode() for details. This probably should be a memcpy of MAX size 32 instead of a string copy. You change won't break anything I don't think, but i'll fix it up so the intent of the code is a little more clear. cheers, jerry ---------------------------------------------------------------------- Hewlett-Packard ------------------------- http://www.hp.com SAMBA Team ---------------------- http://www.samba.org GnuPG Key ---- http://www.plainjoe.org/gpg_public.asc "You can never go home again, Oatman, but I guess you can shop there." --John Cusack - "Grosse Point Blank" (1997) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (GNU/Linux) Comment: For info see http://quantumlab.net/pine_privacy_guard/ iD8DBQE+ZKlsIR7qMdg1EfYRAm5RAKCXW+XAz91RTeL7EnSYNd5RQlqF7gCgpmkf dEHvZ+v2VNtrkPw+Y+ENgVs= =qS3b -----END PGP SIGNATURE-----