On Sat, 2003-03-22 at 11:21, Volker Lendecke wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, Andrew! > > Thinking twice and arguing with you sometimes really helps. Thanks! > > This is my second attempt that is a lot more robust and less > intrusive.
This looks *much* better. Thanks! For my part, I'll get you a doco on idmap and groups this evening :-) > + if (!IS_SAM_CHANGED(sampass, element)) { > + return; > + } The only other case to watch is when we 'add' accounts from another SAM. pdbedit -i foo -o ldap. They are not marked as 'changed' - perhaps they should be. The other option is to detect the 'add' flag and treat as 'changed'. This is what the old code did. (yes, it was ugly :-)). Also, you should cope with NULL as well as "" in your strlen(newval) > 0 test for values we should delete. A slightly more clear comment that "" or NULL -> delete would also be good. Again, this looks like a very good patch! Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
signature.asc
Description: This is a digitally signed message part