On Tue, 2013-06-11 at 19:03 +0200, Andreas Calvo wrote:
> A more detailed output:
> [root@sauron ~]# netstat -tnp|grep 445|grep "192.168.0.222"|grep 55257
> tcp       24      0 192.168.0.222:55257         192.168.0.222:445
> ESTABLISHED 17417/samba
> tcp        0      0 192.168.0.222:445           192.168.0.222:55257
> ESTABLISHED 23713/smbd
> 
> Note that 192.168.0.222 is the IP address of the samba server.
> This occurs when the backup agent starts running.
> It seems that samba it's connecting to itself, and the socket remains open.

This has been fixed in master and in v4-0-test for the next 4.0.x
release with the attached patch. 

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

>From 1d610ce1a14f5a97c9b5cacca839b245df4bae6a Mon Sep 17 00:00:00 2001
From: Stefan Metzmacher <[email protected]>
Date: Fri, 31 May 2013 16:04:26 +0200
Subject: [PATCH] s4:winbind: don't leak libnet_context into the main event
 context (bug #9929)

This needs to be a talloc child of struct wbsrv_domain
otherwise the cleanup of a broken connection doesn't work.

The following command can trigger the leak on a domain controller.

root@dc:~/samba# ls -l /var/lib/samba/sysvol/samba.private/
total 16
drwxrwx---+ 5 root 3000000 4096 May 14 14:46 Policies
drwxrwx---+ 2 root 3000000 4096 May 14 11:45 scripts

gid 3000000 belongs to Builtin\Administrators.

The code triggers a ncacn_np: connection to the local smbd
and complains that domain BUILTIN is not available:

[2013/05/29 17:28:03,  2] ../source4/winbind/wb_init_domain.c:376(init_domain_recv_queryinfo)
  Expected domain name BUILTIN, DC dc.samba.private said SAMBA

In that case the connection was not closed, which is fixed by this commit.

Using ncalrpc: for all local SIDs and serving the BUILTIN domain is
a project for another day...

Signed-off-by: Stefan Metzmacher <[email protected]>

Reviewed-by: Andrew Bartlett <[email protected]>

Autobuild-User(master): Andrew Bartlett <[email protected]>
Autobuild-Date(master): Tue Jun  4 11:05:09 CEST 2013 on sn-devel-104
(cherry picked from commit 097a8c723925d3e35606215cb16be28a37b0112e)

Autobuild-User(v4-0-test): Karolin Seeger <[email protected]>
Autobuild-Date(v4-0-test): Wed Jun  5 13:57:16 CEST 2013 on sn-devel-104
---
 source4/winbind/wb_init_domain.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/source4/winbind/wb_init_domain.c b/source4/winbind/wb_init_domain.c
index 5e2aa47..70dbaa9 100644
--- a/source4/winbind/wb_init_domain.c
+++ b/source4/winbind/wb_init_domain.c
@@ -144,6 +144,8 @@ struct composite_context *wb_init_domain_send(TALLOC_CTX *mem_ctx,
 
 	state->domain->libnet_ctx = libnet_context_init(service->task->event_ctx, 
 							service->task->lp_ctx);
+	if (state->domain->libnet_ctx == NULL) goto failed;
+	talloc_steal(state->domain, state->domain->libnet_ctx);
 
 	/* Create a credentials structure */
 	state->domain->libnet_ctx->cred = cli_credentials_init(state->domain);
-- 
1.7.11.7

-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Reply via email to