-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Gerald (Jerry) Carter wrote:
> Gerald (Jerry) Carter wrote:
>>> Geoffrey Scott wrote:
>>>
>>>>> On a debian Sarge box this is what I get in the log for the machine
>>>>> connected from after using the mmc plugin:
>>>>>
>>>>> sh: line 1: /usr/lib/samba/svcctl/NETLOGON: No such file or directory
>>>>> sh: line 1: /usr/lib/samba/svcctl/Spooler: No such file or directory
>>>>> sh: line 1: /usr/lib/samba/svcctl/Spooler: No such file or directory
>>>
>>> I can't reproduce this failure anymore. I have you log files but
>>> I need your smb.conf.
>
> Ahhh....ok. Apparently, there's a bug when you don't list any
> external services in smb.conf. Patch forthcoming.
And here's the patch. Some older code that didn't get removed
during the latest rewrite.
cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFD6gkNIR7qMdg1EfYRAvAnAJ9KVqfkhTioqy6qu1zDe3bf4SSiRACguib5
kEHh8BfbiPq4Xem8RPmPr3M=
=HsN2
-----END PGP SIGNATURE-----
Index: services/services_db.c
===================================================================
--- services/services_db.c (revision 13391)
+++ services/services_db.c (working copy)
@@ -436,7 +436,7 @@
for ( i=0; builtin_svcs[i].servicename; i++ )
add_new_svc_name( key, subkeys, builtin_svcs[i].servicename );
- for ( i=0; service_list[i]; i++ ) {
+ for ( i=0; service_list && service_list[i]; i++ ) {
/* only add new services */
if ( regsubkey_ctr_key_exists( subkeys, service_list[i] ) )
Index: param/loadparm.c
===================================================================
--- param/loadparm.c (revision 13391)
+++ param/loadparm.c (working copy)
@@ -1655,8 +1655,6 @@
Globals.bASUSupport = True;
- Globals.szServicesList = str_list_make( "Spooler NETLOGON", NULL );
-
/* User defined shares. */
pstrcpy(s, dyn_LOCKDIR);
pstrcat(s, "/usershares");
Index: lib/util_str.c
===================================================================
--- lib/util_str.c (revision 13391)
+++ lib/util_str.c (working copy)
@@ -1852,6 +1852,9 @@
{
int i = 0;
+ if ( ! list )
+ return 0;
+
/* count the number of list members */
for ( i=0; *list; i++, list++ );
Index: rpc_server/srv_svcctl_nt.c
===================================================================
--- rpc_server/srv_svcctl_nt.c (revision 13391)
+++ rpc_server/srv_svcctl_nt.c (working copy)
@@ -72,7 +72,7 @@
/* services listed in smb.conf get the rc.init interface */
- for ( i=0; service_list[i]; i++ ) {
+ for ( i=0; service_list && service_list[i]; i++ ) {
svcctl_ops[i].name = talloc_strdup( svcctl_ops, service_list[i]
);
svcctl_ops[i].ops = &rcinit_svc_ops;
}
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/listinfo/samba
