On Thu, Aug 28, 2008 at 10:02:51PM +0000, simo wrote:
> On Thu, 2008-08-28 at 14:53 -0700, Jeremy Allison wrote:
> > On Thu, Aug 28, 2008 at 05:31:50PM -0400, Steve Thompson wrote:
> > > On Thu, 28 Aug 2008, Jeremy Allison wrote:
> > >
> > > >Can you try using smbclient to do a large file transfer from
> > > >another client Linux box and time that please ?
> > >
> > > Minor rant. One thing that slightly bugs me about smbclient is that it
> > > reports the transfer rate as "kb/s", which means nothing to me. Is this
> > > "KB/s" or "Kb/s"? Well, it's the former: kilobytes per second. So
> > > shouldn't it say "KB/s"?
> >
> > Easily fixed. I'll probably do that.
>
> If we want to be standards compliant then we should write KiB/s[1] not
> Kb/s and MiB/s[2] and GiB/s[3]
>
> :-D
Yuk. I was thinking more this...
diff --git a/source/client/client.c b/source/client/client.c
index 1c0dff9..85f653e 100644
--- a/source/client/client.c
+++ b/source/client/client.c
@@ -1080,7 +1080,7 @@ static int do_get(const char *rname, const char
*lname_in, bool reget)
get_total_time_ms += this_time;
get_total_size += nread;
- DEBUG(1,("(%3.1f kb/s) (average %3.1f kb/s)\n",
+ DEBUG(1,("(%3.1f KiloBytes/sec) (average %3.1f
KiloBytes/sec)\n",
nread / (1.024*this_time + 1.0e-4),
get_total_size / (1.024*get_total_time_ms)));
}
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/listinfo/samba
