> -----Original Message-----
> From: Raimund Jacob [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, December 04, 2002 11:09 PM
> To: SAPDB mailing list
> Subject: comments on 7.4. JDBC driver
>
>
> hello * (esp. the JDBC guys at SAP)!
>
> i recently had a look at the JDBC driver because i wanted the
> ValueOverflow exception to tell me how much space is
> available and how
> much was attempted to write. anyone cares for a patch ?
Hmm. There is the java.sql.DataTruncation class, although not
yet supported/used/thrown by the driver. Its meaning seems to
cover what you try to intend, so there is no reason to go
propietary ways for implementing some feature like this. I'll
look how much effort it is to support DataTruncation
appropriately. However this is 'not nice designed' in JDBC,
therefore we left it currently out of the driver (You have
to throw a DataTruncation, it is an SQLWarning (!), thus
possibly a lot of people will get a lot of never-seen
SQLExceptions that are confusing at least).
>
> however, for that i had to recompile the driver. first, the
> messages.properties are not part of the source distribution. i think
> this is a bug in the built.xml. unfortunately i am too stupid to spot
> that error (and my ant 1.4.1 isnt good enough, too it seems).
We use Ant 1.5.x, and as I remember for a reason. The build.xml
in the CVS should normally do it. Yes, the properties were not
included in the src.jar, and yes, this is a kind of bug.
>
> because of the missing messages the driver NullPointers when
> it throws
> an exception. looking in MessageTranslator.java i see that it should
> throw a MissingResourceExcpetion but that one is caught and disabled
> resulting in the NullPointer (line 134 in translate()). i think the
> obvious fix would be to remove the try {} block in
> getMessages(). this
> would make the MissingResourceException be shown to the user.
I changed it so that the exception handling will honor the exotic
case that no messages at all are available, although this really
should not happen, especially as we have a test that checks the
presence and completeness of the messages we provide.
>
> should i send patches ?
>
Think it is not necessary - the property things are obvious, and the
other looks currently like a bigger change for me - especially when
paying respect to the setMaxFieldSize() methods in Statement.
> --
> Raimund Jacob
> \|/ ____ \|/
> Pinuts Media+Science GmbH "@'/ ,. \`@"
> Potsdamer Str. 96 /_| \__/ |_\
> D-10785 Berlin \__U_/
> http://www.pinuts.de/ voice: +49 30 590090322 fax: +49 30 590090390
>
> _______________________________________________
> sapdb.general mailing list
> [EMAIL PROTECTED]
> http://listserv.sap.com/mailman/listinfo/sapdb.general
>
_______________________________________________
sapdb.general mailing list
[EMAIL PROTECTED]
http://listserv.sap.com/mailman/listinfo/sapdb.general
