Hi,

I cannot clearly understand what you intended with the first patch,
perhaps you can more precisely describe the error situation/condition
(i.e. what was the source java class, and what was the column type).

Your second patch did create an endless loop when setTimeStamp(i, x)
was called with x=null. I decided not to apply this one, but 
applying a fix that resolves this issue in the conversion itself
in a similar and consistent way (and found some other bug that was
hidden in there).

Thanks
Alexander Schr�der
SAP Labs Berlin

> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
> Sent: Saturday, December 21, 2002 12:43 PM
> To: [EMAIL PROTECTED]
> Subject: Fw: SapDB JDBC driver patch
> 
> 
> Hello,
> 
> (Forwarding as the original message doesn't seem to make it 
> to the list)
> 
> Regards,
> Wojtek
> 
> ----
> 
> This patch fixes the problem when using 
> CallableStatementSapDB.setObject (
> index, object, type ) with type =
> Types.DATE or Types.TIME or Types.TIMESTAMP. Unpatched 
> version didn't work
> correctly (exception: invalid timestamp format: ISO), because 
> of timezone
> included in Timestamp (and SapDB does not support timezones 
> in timestamp
> values).
> 
> The second fix makes setTimestamp (index,timestamp) and setTimestamp
> (index,timestamp,calendar) coherent and working properly. Unpatched
> implementation of 2-parameter setTimestamp did not work 
> correctly (the same
> reason as above)
> 
> --
> Marek
> (See attached file: CallableStatementSapDB.java.diff)
> 
> 
_______________________________________________
sapdb.general mailing list
[EMAIL PROTECTED]
http://listserv.sap.com/mailman/listinfo/sapdb.general

Reply via email to