Right now, if a user inputs a bad address with UPS or USPS shipping
modules (and maybe others) there won't be any shipping choices. This
is documented.
However, the payship form has a clean_shipping method that will fail
in this case (since not shipping and self.tempCart.is_shippable). The
validation error won't be displayed because the form.shipping_hidden =
True, but the user will be put back on the payship page. The user
doesn't get an error message, but they also can't move forward.
It seems to me that we need to handle this explicitly. If
cart.is_shippable and len(shipping_choices) == 0 then we have a
problem. Maybe we should throw a 500? Maybe we should have an error
message ("There are no valid shipping methods. Perhaps you entered
your address incorrectly?"). I know it is very difficult to tell why
there are no shipping_choices, but it seems like we need to have a
plan for this situation.
It would be very nice to send them back to the address page with a
validation error message on the address form, but that isn't always
the source of the error.
Any ideas on how we could fix this?
Alex
--
You received this message because you are subscribed to the Google Groups
"Satchmo users" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/satchmo-users?hl=en.
