We have not made any changes since this was identified so the answer is yes, they could still show up in error emails.
-Chris On Fri, Jun 15, 2012 at 2:37 PM, Orion Vianna <guybrush....@gmail.com>wrote: > Hello, > > Is it safe to use django error emails? > Are credit card details still being sent in the latest version? > Thank you for all your work on Satchmo! > > -Orion > > > On 10/26/2011 11:52 AM, Chris Moffitt wrote: > > Ahhh. I didn't know that. We should definitely put this in place. > > I'm a bit swamped right now but if someone wants to put in a ticket with > this info, I'd appreciate it. > > -Chris > > On Wed, Oct 26, 2011 at 10:03 AM, scjohn <goclem...@gmail.com> wrote: > >> The Django development version provides a method for filtering this >> information, may be a good place to start. >> >> >> https://docs.djangoproject.com/en/dev/howto/error-reporting/#filtering-error-reports >> >> John >> >> On Oct 25, 5:37 pm, Chris Moffitt <ch...@moffitts.net> wrote: >> > This is the default Django error handler in action. To override the >> > inclusion of certain POST values, we'd need to define our own custom >> > AdminEmailHandler as described here - >> https://docs.djangoproject.com/en/1.3/topics/logging/ >> > >> > It looks like we'd have to override the emit method to try to filter out >> > sensitive post information. I didn't dive into this to see what is >> involved >> > but if someone wants to tackle it, it does seem like a good idea. >> > >> > -Chris >> > >> > >> > >> > >> > >> > >> > >> > On Tue, Oct 25, 2011 at 11:57 AM, evigmostad <evigmos...@gmail.com> >> wrote: >> > > A customer was checking out and we either had memcached restart or had >> > > a timeout (site load). Received an error email that contained POST >> > > data, includingfull credit card details! How do we suppress the POST >> > > data if this type of error occurs? >> > >> > > [Django] ERROR (EXTERNAL IP): Internal Server Error: /store/checkout/ >> > > credit/ >> > >> > > Traceback (most recent call last): >> > >> > > File "/home/httpd/djcode/django/core/handlers/base.py", line 111, in >> > > get_response >> > > response = callback(request, *callback_args, **callback_kwargs) >> > >> > > File "/home/httpd/djcode/django/views/decorators/cache.py", line 79, >> > > in _wrapped_view_func >> > > response = view_func(request, *args, **kwargs) >> > >> > > File "/home/httpd/djcode/amart/satchmo/apps/payment/modules/cim/ >> > > views.py", line 6, in pay_ship_info >> > > return payship.credit_pay_ship_info(request, >> > > config_get_group('PAYMENT_CIM')) >> > >> > > File "/home/httpd/djcode/amart/satchmo/apps/payment/views/ >> > > payship.py", line 213, in credit_pay_ship_info >> > > return base_pay_ship_info(request, payment_module, >> > > credit_pay_ship_process_form, template) >> > >> > > File "/home/httpd/djcode/amart/satchmo/apps/payment/views/ >> > > payship.py", line 204, in base_pay_ship_info >> > > results = form_handler(request, contact, working_cart, >> > > payment_module) >> > >> > > File "/home/httpd/djcode/amart/satchmo/apps/payment/views/ >> > > payship.py", line 74, in credit_pay_ship_process_form >> > > form.save(request, working_cart, contact, payment_module, >> > > data=data) >> > >> > > File "/home/httpd/djcode/amart/satchmo/apps/payment/forms.py", line >> > > 659, in save >> > > super(CreditPayShipForm, self).save(request, cart, contact, >> > > payment_module, data=data) >> > >> > > File "/home/httpd/djcode/amart/satchmo/apps/payment/forms.py", line >> > > 402, in save >> > > self.order = get_or_create_order(request, cart, contact, data) >> > >> > > File "/home/httpd/djcode/amart/satchmo/apps/payment/utils.py", line >> > > 50, in get_or_create_order >> > > shipping=shipping, discount=discount, update=update) >> > >> > > File "/home/httpd/djcode/amart/satchmo/apps/payment/utils.py", line >> > > 70, in pay_ship_save >> > > update_shipping(new_order, shipping, contact, cart) >> > >> > > File "/home/httpd/djcode/amart/satchmo/apps/shipping/utils.py", line >> > > 11, in update_shipping >> > > shipper.calculate(cart, contact) >> > >> > > File "/home/httpd/djcode/amart/satchmo/apps/shipping/modules/fedex/ >> > > shipper.py", line 167, in calculate >> > > shop_details = Config.objects.get_current() >> > >> > > File "/home/httpd/djcode/amart/satchmo/apps/satchmo_store/shop/ >> > > models.py", line 62, in get_current >> > > shop_config = keyedcache.cache_get("Config", site) >> > >> > > File "/home/httpd/djcode/amart/satchmo/apps/keyedcache/__init__.py", >> > > line 198, in cache_get >> > > obj = cache.get(key) >> > >> > > File "/home/httpd/djcode/django/core/cache/backends/memcached.py", >> > > line 58, in get >> > > val = self._cache.get(key) >> > >> > > File "/usr/local/lib/python2.7/dist-packages/python_memcached-1.45- >> > > py2.6.egg/memcache.py", line 779, in get >> > > return self._get('get', key) >> > >> > > File "/usr/local/lib/python2.7/dist-packages/python_memcached-1.45- >> > > py2.6.egg/memcache.py", line 762, in _get >> > > rkey, flags, rlen, = self._expectvalue(server) >> > >> > > File "/usr/local/lib/python2.7/dist-packages/python_memcached-1.45- >> > > py2.6.egg/memcache.py", line 874, in _expectvalue >> > > if line[:5] == 'VALUE': >> > >> > > TypeError: 'NoneType' object is not subscriptable >> > >> > > POST data followed. >> > >> > > -- >> > > You received this message because you are subscribed to the Google >> Groups >> > > "Satchmo users" group. >> > > To post to this group, send email to satchmo-users@googlegroups.com. >> > > To unsubscribe from this group, send email to >> > > satchmo-users+unsubscr...@googlegroups.com. >> > > For more options, visit this group at >> > >http://groups.google.com/group/satchmo-users?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "Satchmo users" group. > To post to this group, send email to satchmo-users@googlegroups.com. > To unsubscribe from this group, send email to > satchmo-users+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/satchmo-users?hl=en. > -- You received this message because you are subscribed to the Google Groups "Satchmo users" group. To post to this group, send email to satchmo-users@googlegroups.com. To unsubscribe from this group, send email to satchmo-users+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/satchmo-users?hl=en.
