This mail is an automated notification from the task tracker
of the project: Savane.
/**************************************************************************/
[task #116] Latest Modifications:
Changes by:
Mathieu Roy <[EMAIL PROTECTED]>
'Date:
jeu 21.10.2004 à 18:20 (Europe/Paris)
What | Removed | Added
---------------------------------------------------------------------------
Should Start On | sam 31.01.2004 à 01:00 | sam 31.01.2004 à 00:00
Should be Finished on | mar 31.01.2006 à 01:00 | mar 31.01.2006 à 00:00
------------------ Additional Follow-up Comments ----------------------------
It is not important to combine stuff in a single general.php.
In fact, in some cases it should be even avoided.
The rewrite of this part is mainly a matter of output style and coding style.
For instance, first the code is full of echo, while no we use only print (see
doc/devel/CODING_STYLE).
Also, the page is created by calls to $HTML->header() while it should be done with
functions like site_user_header();
As result, the top menu is missing (should be created) and the title is included in an
h3, unlike on the rest of the frontend.
When you view a job, like https://gna.org/people/viewjob.php?group_id=270&job_id=34
you end up with awkward title still in h1, with information written very differently
than in any other part of the frontend (fields like "From:" does not use the css class
preinput)
The point is getting that area looking like the others. For the code related stuff, if
you have doubt about functions (stuff apparently deprecated -- function missing), send
first a mail to the list savane-dev (or post a comment on this item).
/**************************************************************************/
[task #116] Full Item Snapshot:
URL: <http://gna.org/task/?func=detailitem&item_id=116>
Project: Savane
Submitted by: Mathieu Roy
On: dim 01.02.2004 à 20:11
Should Start On: sam 31.01.2004 à 00:00
Should be Finished on: mar 31.01.2006 à 00:00
Category: Web Frontend
Priority: 1 - Later
Resolution: None
Privacy: Public
Assigned to: None
Percent Complete: 0%
Status: Open
Effort: 0.00
Planned Release:
Summary: people area: complete reorganization of code and web style
Original Submission: This part is not coherent with the rest of Savane in many
regards. It must be largelly rewritten.
Commentaires
------------------
-------------------------------------------------------
Date: jeu 21.10.2004 à 18:20 By: Mathieu Roy <yeupou>
It is not important to combine stuff in a single general.php.
In fact, in some cases it should be even avoided.
The rewrite of this part is mainly a matter of output style and coding style.
For instance, first the code is full of echo, while no we use only print (see
doc/devel/CODING_STYLE).
Also, the page is created by calls to $HTML->header() while it should be done with
functions like site_user_header();
As result, the top menu is missing (should be created) and the title is included in an
h3, unlike on the rest of the frontend.
When you view a job, like https://gna.org/people/viewjob.php?group_id=270&job_id=34
you end up with awkward title still in h1, with information written very differently
than in any other part of the frontend (fields like "From:" does not use the css class
preinput)
The point is getting that area looking like the others. For the code related stuff, if
you have doubt about functions (stuff apparently deprecated -- function missing), send
first a mail to the list savane-dev (or post a comment on this item).
-------------------------------------------------------
Date: jeu 21.10.2004 à 18:06 By: Michael Casadevall <sonicmctails>
Can you provide more clarification (aka specific examples) on how the people area must
be rewritten. Currently, I am seeing that the API function names are different
(people_job_*, etc.), and those three files should be combined into a single
general.php file like the rest of the includes.
For detailed info, follow this link:
<http://gna.org/task/?func=detailitem&item_id=116>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Savane-dev mailing list
[EMAIL PROTECTED]
https://mail.gna.org/listinfo/savane-dev
