This is an automated notification sent by Gna!.
It relates to:
bugs #1957, project Savane
==============================================================================
LATEST MODIFICATIONS of bugs #1957:
==============================================================================
Posted by: Sylvain Beucler <beuc>
Posted on: 2005-01-2 14:23 (GMT)
_______________________________________________________
Follow-up Comment:
AFAIR a version of Savane was saving the SSH keys without an ending newline (I
think, not the latest one), and another one was doing so. The changes, I
think, happened when the interface to enter SSH keys was changed from a
<textarea> to a sequence of <input>.
So, if the user submitted his key with the previous version, it would be
always recreated with the new version, because the authorized_keys present in
the system would have ending newline, and the database would not.
An alternative way to fix the problem would be to create a script to add a
newline to all the registered SSH keys, put in update/.
In general, I think it is best to ask first and then change, instead of
changing first and then asking, don't you think? :)
It is strange that the test can fail; do you have an sample list of keys
(database and system versions) that is recreated because of the test?
==============================================================================
OVERVIEW of bugs #1957:
==============================================================================
URL:
<http://gna.org/bugs/?func=detailitem&item_id=1957>
Summary: non working code related to ssh keys prefix
Project: Savane
Submitted by: yeupou
Submitted on: Sun 01/02/2005 at 14:08
Category: Backend
Severity: 3 - Average
Priority: B - Low
Status: None
Privacy: Public
Assigned to: beuc
Open/Closed: Open
Release: DEV_2004-12-28_Savannah
Planned Release:
_______________________________________________________
I commented a bit of code in the function GetUserSSHKeyReal that was causing
the output to be different than the actual content of the file.
The purpose of this function is to return the exact content of the ssh user
file, in the same format as the equivalent field in the database. It is
important that it stays that way. I'm not sure to understand the purpose of
the code commented. As least, if this code is really needed, a comment should
be added.
At the same time, I remove a bit of code in sv_user that was apparently
removing line break (under the form ###, since it is the format of the ssh key
in the database). It was not obvious to me why such removal was necessary - it
was before a comparison, having 2 extra line break would not break the
comparison, as long as we have these each time.
_______________________________________________________
Follow-up Comments:
-------------------------------------------------------
Date: Sun 01/02/2005 at 14:23 By: Sylvain Beucler <beuc>
AFAIR a version of Savane was saving the SSH keys without an ending newline (I
think, not the latest one), and another one was doing so. The changes, I
think, happened when the interface to enter SSH keys was changed from a
<textarea> to a sequence of <input>.
So, if the user submitted his key with the previous version, it would be
always recreated with the new version, because the authorized_keys present in
the system would have ending newline, and the database would not.
An alternative way to fix the problem would be to create a script to add a
newline to all the registered SSH keys, put in update/.
In general, I think it is best to ask first and then change, instead of
changing first and then asking, don't you think? :)
It is strange that the test can fail; do you have an sample list of keys
(database and system versions) that is recreated because of the test?
==============================================================================
This item URL is:
<http://gna.org/bugs/?func=detailitem&item_id=1957>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Savane-dev mailing list
[email protected]
https://mail.gna.org/listinfo/savane-dev
