Hi,

I'd like to suggest the attached patch for the output of viewgpg.php. I know 
it breaks the "string freeze", but I think we could cope with that. 
Moreover, I think it would be a nicer output and also correct (think of 
user names ending with an "s"). It's also easier to translate ...

Cheers,

-- 

Tobias

    Time is what keeps things from happening all at once.
Index: frontend/php/people/viewgpg.php
===================================================================
RCS file: /cvs/savane/savane/frontend/php/people/viewgpg.php,v
retrieving revision 1.12
diff -u -b -r1.12 viewgpg.php
--- frontend/php/people/viewgpg.php	27 Jun 2005 10:35:14 -0000	1.12
+++ frontend/php/people/viewgpg.php	27 Jun 2005 20:16:09 -0000
@@ -44,7 +44,15 @@
 			      'toptab'=>'keys'));

       print '<h3>';
-      printf (_("%s's GPG Key:"),db_result($result,0,'user_name'));
+      $realname = db_result($result, 0, 'realname');
+      if (strlen($realname))
+        {
+          printf (_("GPG key of %s (%s)"), $realname, db_result($result, 0, 'user_name'));
+	}
+      else
+        {
+          printf (_("GPG key of %s"), db_result($result, 0, 'user_name'));
+	}
       print '</h3>';

       if (!db_result($result,0,'gpg_key'))

Attachment: pgp1tHEVUs2dE.pgp
Description: PGP signature

Reply via email to