This mail is an automated notification from the bugs tracker
of the project: Savane.
/**************************************************************************/
[bugs #416] Latest Modifications:
Changes by:
Vincent Caron <[EMAIL PROTECTED]>
'Date:
Thu 06/10/04 at 14:21 (Europe/Paris)
------------------ Additional Follow-up Comments ----------------------------
Sure, OK for the quick fix, I'm having a try.
I was actually lead to think along the same lines ("this thing need to be
totally CSS'ed one day, die tables, die !").
/**************************************************************************/
[bugs #416] Full Item Snapshot:
URL: <http://gna.org/bugs/?func=detailitem&item_id=416>
Project: Savane
Submitted by: Vincent Caron
On: Thu 06/10/04 at 12:20
Category: Web Frontend
Severity: 3 - Average
Priority: C - Normal
Resolution: None
Assigned to: None
Status: Open
Release:
Planned Release:
Summary: News HTML layout is broken
Original Submission: As read from /index.php:
$HTML->box1_top(...);
echo news_show_latest(...);
$HTML->box1_bottom();
The trouble is that box1_top() starts a <table><tr><td>, box1_bottom() ends
with </td></tr></table, and news_show_latest() should ouput regular content.
But news_show_latest() makes assumption on its context, and outputs news items
in <tr><td>...</td></tr> elements, trying to extend the box model, ant it fails
:
[box1_top:]
<table>
<tr>
<td>
[news_show_latest:]
<tr><td> ... item ... </td></tr>
<tr><td> ... item ... </td></tr>
[box1_bottom:]
</td>
</tr>
</table>
Proposed solution:
1- improve the box model in Layout.php to accept multiple rows of content
2- move the box_ calls into news_show_latest, have only the global news
header passed as argument to news_show_latest
Follow-up Comments
------------------
-------------------------------------------------------
Date: Thu 06/10/04 at 14:21 By: zerodeux
Sure, OK for the quick fix, I'm having a try.
I was actually lead to think along the same lines ("this thing need to be
totally CSS'ed one day, die tables, die !").
-------------------------------------------------------
Date: Thu 06/10/04 at 14:08 By: yeupou
I do not agree with the idea 2 since I think it will break several other pages
and will reduce the flexibility of news_show_latest()
Also, the box model already accept multiple row. In an awkward way, but still
it works. Doing the kind of modification are likely to break several other
things.
I suggest that we just stick to basic fix, at least on trunk.
Proposal:
Modifying news_show_latest so it prints "</td></tr><tr><td>" the begin of any
newline except the first one.
I do not remember exactly how looks like this function but I think it should be
feasible. Moreover, it is in a similar way that multiples rows (that are in
every tables) are handled. The issue here is only the fact it print from the
start a <tr><td> while it should assume this is already done (like it already
assumes that <table> is open).
I do not think the way the html output is implemented is wonderfull but
changing it would require a dense work - so to avoid breaking other parts or
break the logic of the whole thing, we should stick to it until we implement
something different.
Regards,
For detailed info, follow this link:
<http://gna.org/bugs/?func=detailitem&item_id=416>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
