Hi, On Mon, Apr 28, 2008 at 10:27:30AM -0700, nick alvaro wrote: > function search_send_header was causing me some issues so I had to > change it. I called for the search_exact function in the > search_send_header function's "if ($type_of_search == "soft")" > expression and moved each "<h3>" to each $type_of_search expression > as well. This is because the exact search result has to come after > the header is called and after the Search Criteria box is called but > before the heading 3 is printed out. > > Here are my proposed changes: *snip!*
At first glance it looks good. I have a few technical suggestions: - Use db_execute for database access. It is similar to AdoDB's Execute function, and does a secure escaping for PHP variables included in the query. - Can you send your changes as a patch? You could use 'git diff' for instance. It's easier to review changes that way. - You could use a JOIN to perform only one query instead of two :) > > ____________________________________________________________________________________ > Be a better friend, newshound, and > know-it-all with Yahoo! Mobile. Try it now. > http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ Sure, but this pretty off-topic, don't you think? :) Thanks, -- Sylvain
