Hi, Ocaml-magic is only optional for now, so it's good that decoders such as ogg and wav don't need it. The only problematic decoder is MP3 because it usually succeeds at decoding anything. To me even the MP3 problem is a minor issue but it's fixed anyway: if ocaml-magic is available then a mime check happens prior to mp3 decoding.
I don't think we should waste our time on more mime checks (cleanup the existing code instead!). Even if there is a mime check, it's only superficial so it's still good to try the actual decoder to check that data is well-formed. Another problem of mime checks is that you have to figure out all the possible mime strings that will come out of valid files. Cheers, David ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ Savonet-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/savonet-devl
