Hi, Romain Beauxis wrote: > I am on my way somewhere in CZ, so I took some time to look into the new > input.voip work done by Sam (cheers sam!).
Cheers too :) and I hope that you are having fun there. > I would have few remarks: > * I believe the very high load is generated by the infinite loop waiting for > new messages. There should be a way to make this more safe. Unfortunately, this is not true. The function for getting messages is blocking until there is a new message. Moreover there are only very few message as you can see with the printf (and the c_api example only starts to be CPU consuming when there is a call which means that it's really audio handling which consumes CPU). > In particular, as for now I believe the code may answer to several calls at > once :-) I'd like to have this possibility. For a "libre antenne" you can have several callers and I'd like to keep this possibility in mind when designing the API. > * I will look for a more proper use of the fd for reading data. In > particular, > it shouldn't need a specific thread, the duppy scheduler should be sufficient > (see input.external for instance). I don't have an opinion on this. But if you want a duppy thread, you'll have to implement it by yourself ;) > * I am almost sure that there should be a way to obtain data in the PCM > format > we need. The file <opal/codec/opalwavefile.h> is an example of this. This means that we'd have to switch to the C++ API. I'm in favor of this anyway since the C API looks very limited. The implementation of the C API could be a good starting point however. > I will try to code some of these remarks. I'm looking forward for your > comments.. I can't wait to see what you manage to do... ++ Sam. ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Savonet-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/savonet-devl
