[
http://dev.sourcefabric.org/browse/LS-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Romain Beauxis closed LS-462.
-----------------------------
Fix Version/s: 1.0
Resolution: Fixed
Thank you very much for this report, this kind of issues should never happen..
For the shake of documenting the issue, I've been too confident and did not try
something I though was trivial.. It turns out that the semantics of exception
catching in OCaml is tricky and confusing.. Here's the diff of the fix:
Index: decoder/ogg_decoder.ml
===================================================================
--- decoder/ogg_decoder.ml (révision 8121)
+++ decoder/ogg_decoder.ml (copie de travail)
@@ -201,7 +201,7 @@
Ogg_demuxer.decode_video decoder video_feed
with
| Ogg_demuxer.End_of_stream -> reset buffer
- | Ogg.Not_enough_data
+ | Ogg.Not_enough_data -> feed ()
| Ogg.Out_of_sync when source = `Stream -> feed ())
end
What I did not see is that the "when" condition implicitely applied to both
cases..
> Cannot play vorbis ogg files.
> -----------------------------
>
> Key: LS-462
> URL: http://dev.sourcefabric.org/browse/LS-462
> Project: Liquidsoap
> Issue Type: Bug
> Affects Versions: 1.0 beta
> Environment: Ubuntu 10.10 64-bit
> Reporter: Martin Konecny
> Priority: Major
> Fix For: 1.0
>
> Attachments: 8076.log, 8122.log
>
>
> Somewhere after revision 8076 ogg vorbis files do not not play anymore.
> Command used:
> ./liquidsoap 'out(playlist("/home/martin/Desktop/x"))'
> This issue exists on the latest revision 8122
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web. Learn how to
best implement a security strategy that keeps consumers' information secure
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Savonet-devl mailing list
Savonet-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-devl
