[ 
http://dev.sourcefabric.org/browse/LS-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Baelde updated LS-478:
----------------------------

    Description: 
$ ./src/liquidsoap 'output.dummy(video.add_text("foo",blank()))'
Invalid value at line 1, char 28-42: Library not initialized.

The problem is that SDL is only initialized when streaming starts, just before 
sources are woken up, but the text operator initializes its font upon creation 
and not upon #wake_up. This in itself is (slightly) incorrect since resources 
should only be allocated within #wake_up and #sleep, but it is useful to check 
that the font exists.

The simplest solution is that all SDL operators call Sdl_utils.init which inits 
with all options if not already done. The current architecture tries to do 
better by not initializing components that don't need to. This is nice but I 
don't see why it's necessary.

  was:
{{{
$ ./src/liquidsoap 'output.dummy(video.add_text("foo",blank()))'
Invalid value at line 1, char 28-42: Library not initialized.
}}}

The problem is that SDL is only initialized when streaming starts, just before 
sources are woken up, but the text operator initializes its font upon creation 
and not upon #wake_up. This in itself is (slightly) incorrect since resources 
should only be allocated within #wake_up and #sleep, but it is useful to check 
that the font exists.

The simplest solution is that all SDL operators call Sdl_utils.init which inits 
with all options if not already done. The current architecture tries to do 
better by not initializing components that don't need to. This is nice but I 
don't see why it's necessary.


> Cannot use video.add_text since SDL init changes
> ------------------------------------------------
>
>                 Key: LS-478
>                 URL: http://dev.sourcefabric.org/browse/LS-478
>             Project: Liquidsoap
>          Issue Type: Bug
>          Components: Liquidsoap
>         Environment: current dev version
>            Reporter: David Baelde
>            Priority: Major
>
> $ ./src/liquidsoap 'output.dummy(video.add_text("foo",blank()))'
> Invalid value at line 1, char 28-42: Library not initialized.
> The problem is that SDL is only initialized when streaming starts, just 
> before sources are woken up, but the text operator initializes its font upon 
> creation and not upon #wake_up. This in itself is (slightly) incorrect since 
> resources should only be allocated within #wake_up and #sleep, but it is 
> useful to check that the font exists.
> The simplest solution is that all SDL operators call Sdl_utils.init which 
> inits with all options if not already done. The current architecture tries to 
> do better by not initializing components that don't need to. This is nice but 
> I don't see why it's necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Savonet-devl mailing list
Savonet-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-devl

Répondre à