[
http://dev.sourcefabric.org/browse/LS-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552#action_15552
]
Romain Beauxis commented on LS-268:
-----------------------------------
So, I am confused.. Isn't this issue already fixed by that code in
http_source's wake_up method:
begin match wait_polling with
| None -> ()
| Some f -> f () ; wait_polling <- None
end ;
?
I have started a branch fixing input.harbor but it needs testings.. which is
what branches are for anyway :-)
> Clean thread management for input.http() (and input.harbor())
> -------------------------------------------------------------
>
> Key: LS-268
> URL: http://dev.sourcefabric.org/browse/LS-268
> Project: Liquidsoap
> Issue Type: Bug
> Components: Liquidsoap
> Priority: Blocker
>
> Currently, when an input.http goes to #sleep, it asks its feeding thread to
> exit, but does not check that it exited. As a consequence, a #wake_up quickly
> after the #sleep could cause (1) the old thread to not exit and hence (2) two
> feeding threads at the same time.
> (Another slightly related issue is that the feeding thread might have
> non-trivial activity during the shutdown phase: it can be in the middle of a
> connection when shutdown starts, and we have to wait for it to start decoding
> before that it notices that it should exit.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself;
WebMatrix provides all the features you need to develop and
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
_______________________________________________
Savonet-devl mailing list
Savonet-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-devl
