[ 
http://dev.sourcefabric.org/browse/LS-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050#action_16050
 ] 

Romain Beauxis commented on LS-525:
-----------------------------------

Hi,

I am not sure why it is working in 0.9.3 but I would clearly expect it to fail 
in this case.

The reason is that in the code your are using, if no "length" metadata is 
passed, mp3 length is computed by decoding the entire file, which is clearly 
too cost-intensive with such a file.

I can propose you two (in fact 3) alternatives:
 * Do not use the length option :)
 * Pass a "length" metadata. I have not read the code yet but I think I 
remember that in this case, the length is taken from this value and thus does 
not require computing the file's length
 * Try the current seek branch in our HG code. This branch has a support for 
computing mp3 length that should be much less cost-intensive. The changes in 
this branch should eventually make it into the default branch soon..

> Audioscrobbler knocked out liquidsoap
> -------------------------------------
>
>                 Key: LS-525
>                 URL: http://dev.sourcefabric.org/browse/LS-525
>             Project: Liquidsoap
>          Issue Type: Bug
>          Components: ocaml-lastfm
>    Affects Versions: 1.0
>         Environment: Debian Squeeze
>            Reporter: Egor
>            Priority: Critical
>
> I use Liquidsoap from SVN trunk, rev. 8219, with modules. After loading large 
> mp3 file (~ 200 − 300mb = ~ 1h30m − 2h00m) to source and sent source to 
> lastfm.nowplaying function with parameter length=true — Liquidsoap gets down. 
> In Liquidsoap 0.9.3 length check works good. In the log falling info does not 
> appear.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
Savonet-devl mailing list
Savonet-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-devl

Répondre à