[
http://dev.sourcefabric.org/browse/LS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Romain Beauxis resolved LS-537.
-------------------------------
Assignee: Romain Beauxis
Fix Version/s: 1.0
Resolution: Fixed
Fixed in 8a446c71e509:
Releasing the Gc lock inside a finalization function was not a good idea!
This was in fact causing a global memory inconsistency, with logs of the
form:
2011/06/21 23:23:15 [decoder:4] Decoder "OGG" failed on "foo.ogg": Bad file
descriptor in lseek()!
Thus, opening API in Vorbis.File has been changed:
* No close callback is passed.
* If no close callback is passed, ov_clear does not
mess with the Gc, thus removing the calls to
grab ocaml global lock.
* Removed exported close function and put all cleaning
in the finalization function.
* Thus, return a Unix.file_descr when opening
a file.
* Changed file opening function to more consistent names.
> Segfault when seeking under stress
> ----------------------------------
>
> Key: LS-537
> URL: http://dev.sourcefabric.org/browse/LS-537
> Project: Liquidsoap
> Issue Type: Bug
> Components: Liquidsoap
> Reporter: Romain Beauxis
> Assignee: Romain Beauxis
> Priority: Critical
> Fix For: 1.0
>
> Attachments: blind_test.liq
>
>
> Wen seeking under stress, liquidsoap can segfault, most likely in relation
> with the Gc.
> Attached is a script from David to reproduce it.
> So far, I have noted that it does happen with only ogg decoding enabled and
> that it may not be related to a finalisation.
> I suspect something fishy around the ogg sync code as it is full of caml
> callbacks from C but it may be something else..
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger.
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today.
http://p.sf.net/sfu/quest-sfdev2dev
_______________________________________________
Savonet-devl mailing list
Savonet-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-devl
