[
http://dev.sourcefabric.org/browse/LS-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545#action_16545
]
Romain Beauxis commented on LS-535:
-----------------------------------
Hi Martin!
Currently, this behaviour is expected:
Regardless of the restart parameters, in case of network issues, an initial
restart is always performed.
Then, if the first restart fails, if restart=false then an exception is raised.
Otherwise (restart=false), the source keeps on trying to restart.
Thus, I am not sure what to do with this ticket. If we believe that the "one
restart regardless of the restart parameter" is not desirable then we have a
bug (easy to fix!). On the contrary, then we have no bug and this ticket could
probably be closed..
> output.shoutcast: restart=false but trying to restart anyway (dynamic context)
> ------------------------------------------------------------------------------
>
> Key: LS-535
> URL: http://dev.sourcefabric.org/browse/LS-535
> Project: Liquidsoap
> Issue Type: Bug
> Affects Versions: 1.0 beta
> Environment: ubuntu 11.04 / hg version.
> Reporter: MartinS4
>
> This issue happens when for example, I add a stream dynamically (thru telnet)
> to a shoutcast listener instance (actually icecast 2.3.2 with shoutcast
> compat listener) for which there is already client connected to it.
> I am quoting myself and David:
> me> What I don't understand is if the connection fail, liquidsoap retry
> me > > every 3s ... but I haven't specified any "restart" properties and it
> me > > seems to be "false" by default ?
> Even when restart=false, the icecast output attempts to reconnect in a
> few cases. Those should be very limited, but you may have found a bug
> here -- this wouldn't be a big surprise, this code was written before
> dynamic outputs were possible. We need to look more into that. Filing
> a bug would be a good way to make sure we don't forget.
> me > Or... The default for restart is not false ? ll try to add a
> restart=false
> me > > and see if it acts differently before filling a bug report.
> It is false by default, except on old liquidsoaps which you can't be
> using since you're playing with dynamic outputs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger.
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today.
http://p.sf.net/sfu/quest-sfdev2dev
_______________________________________________
Savonet-devl mailing list
Savonet-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-devl
