[ 
http://dev.sourcefabric.org/browse/LS-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730#action_17730
 ] 

David Baelde commented on LS-475:
---------------------------------

Ignore my old comment about playlist.safe: the code is already solid enough, it 
filters out invalid entries and rejects the new playlist if it is empty, so an 
invalid new playlist would be ignored by playlist.safe() as expected.

> Clean handling of erroneous URLs
> --------------------------------
>
>                 Key: LS-475
>                 URL: http://dev.sourcefabric.org/browse/LS-475
>             Project: Liquidsoap
>          Issue Type: Bug
>            Reporter: Samuel Mimram
>            Assignee: David Baelde
>            Priority: Major
>
> From the mailing-list:
> out(mksafe(
> fallback([
>     input.http(id="h1","http://localhost:2345/radio";),
>     single("say:fallback")
> ])
> ))
> h1.url http:/localhost:2345/radio
> h1.stop
> h1.start
> results in
> 2011/02/07 03:10:57 [threads:1] Thread "http polling" failed: Invalid
> URL "http:/localhost:2345/radio"!!
> Thread 4 killed on uncaught exception Failure("Invalid URL
> "http:/localhost:2345/radio"!")
> Raised at file "pervasives.ml", line 22, characters 22-33
> 2011/02/07 03:10:57 [main:3] Shutdown started!
> 2011/02/07 03:10:57 [main:3] Waiting for threads to terminate...
> We should handle more cleanly ill-formed URLs.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Savonet-devl mailing list
Savonet-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-devl

Répondre à