[
http://dev.sourcefabric.org/browse/LS-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Baelde reopened LS-460:
-----------------------------
We bumped into this when investigating a problem with smart_cross. This fix has
really brutal and puzzling effects: it forces an end of track if a source
becomes not ready in the middle of a track, but this end of track is not
noticeable by normal users using on_track or on_end, because the fix applies to
them as well and they become not ready just like their source.
It would be nice to refine the fix a little bit. Ideally, we should be able to
revert the fix on smart_cross -- another way to say it is that we shouldn't
have to fix such issues again at the level of operators, if it's done properly
in source.ml.
One idea is to assume is_ready is true while in the middle of the track, but
it's not sure that we can do this cleanly. The real problem is sharing, hence
another idea: disable the fix when the source is not caching.
> Another fundamental problem with the source protocol
> ----------------------------------------------------
>
> Key: LS-460
> URL: http://dev.sourcefabric.org/browse/LS-460
> Project: Liquidsoap
> Issue Type: Bug
> Reporter: David Baelde
> Assignee: David Baelde
> Priority: Major
> Attachments: 460.patch
>
>
> After some thinking about liquidsoap 2, I found something tricky that I never
> noticed before. It didn't take me two attempts to turn it into a bug... The
> following script which crashes liquidsoap with a failed assertion:
> {{{
> q =
> request.queue(queue=[request.create("/home/dbaelde/media/audio/albums/Doors/The
> Doors/01 - The Doors - Break On Through (To The Other Side).mp3")])
> output.dummy(id="bar",mksafe(q))
> output.dummy(id="foo",fallback([amplify(1.,q),blank(duration=1.)]))
> def at(t,s)
> add_timeout(t,{ignore(server.execute(s));(-1.)})
> end
> # TODO on peut aussi faire crasher liq en faisant un non-unit pas ignoré
> # e.g {"foo"} a runtime (minor bug)
> at(3.,"foo.stop")
> at(4.,"bar.skip")
> at(5.,"foo.start")
> }}}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Savonet-devl mailing list
Savonet-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-devl
