#212: really fail on "#get_frame didn't add exactly one break!" ?
------------------------+---------------------------------------------------
Reporter: toots | Owner: admin
Type: Bugs | Status: new
Priority: 5 | Milestone: 0.9.0
Component: Liquidsoap | Version: 0.3.8+svn
Keywords: | Mac: 1
Linux: 1 | Netbsd: 1
Other: 1 | Freebsd: 1
------------------------+---------------------------------------------------
Hi all !
While experiencing with broken ogg streams, I encountered the following
crash:
{{{
2008/12/08 17:04:47 [/tmp/bla(dot)ogg:3] Finished with "/tmp/bla.ogg"
2008/12/08 17:04:47 [/tmp/bla(dot)ogg:2] #get_frame didn't add exactly one
break!
2008/12/08 17:04:47 [threads:1] thread "root" aborts with exception File
"source.ml", line 199, characters 10-16: Assertion failed !
2008/12/08 17:04:47 [main:3] Shutdown started!
2008/12/08 17:04:47 [source:4] ao gets down
2008/12/08 17:04:47 [source:4] src_4382 gets down
2008/12/08 17:04:47 [source:4] src_4381 gets down
2008/12/08 17:04:47 [threads:3] thread "generic queue #1" exited (1
remaining)
Thread 3 killed on uncaught exception Assert_failure("source.ml", 199, 10)
Called from file "operators/switch.ml", line 190, characters 10-18
Called from file "source.ml", line 196, characters 8-26
Called from file "outputs/output.ml", line 134, characters 8-23
Called from file "list.ml", line 69, characters 12-15
Called from file "source.ml", line 258, characters 21-41
Called from file "tools/tutils.ml", line 122, characters 15-18
Re-raised at file "tools/tutils.ml", line 140, characters 21-22
Called from file "thread.ml", line 38, characters 8-14
}}}
The problem seems to be caused by the fact that the ogg stream starts with
an empty stream, which leaded to two breaks being added. (intuitions)
My belief on this topic is that, contratry to the infamous "#get_frame
didn't change the buffer", multiple breaks are a bad thing but are not
fatal.
Mort likely, we probably should treat them as the programmer's fault and
don't crash the users script, but generate a big fat warning, possibly
with our mail in it :)
What do you think ?
--
Ticket URL: <http://savonet.rastageeks.org/ticket/212>
Savonet <http://savonet.rastageeks.org/>
Let's program our stream !
------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you. Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Savonet-trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-trac
