#338: Check bounds for encoding parameters
------------------------+---------------------------------------------------
Reporter: smimram | Owner: admin
Type: Bugs | Status: new
Priority: 1 | Milestone: 1.0 beta
Component: Liquidsoap | Version:
Keywords: | Mac: 1
Linux: 1 | Netbsd: 1
Other: 1 | Freebsd: 1
------------------------+---------------------------------------------------
Old description:
> We should avoid bug reports like the one below: we should check that
> quality of encoding is between 0 and 1 and likewise that other parameters
> are within reasonable bounds.
>
> > >> I have a little problem using the output.icecast and the new syntax.
> > >> Here my lines:
> > >>
> > >> output.icecast(%vorbis(quality=5), mount="hd.ogg", id="oxyOGG",
> > >> name="OxyRadio.net :: Respire et Ecoute!",
> > >> host=oxyHost, port=oxyPort, user=oxyUser,
> > >> password=oxyPassword, genre=oxyGenre, description=oxyDesc,
> url=oxyUrl,
> > >> restart=true,
> > >> radio)
> > >> output.icecast(%vorbis(quality=0),mount="bd.ogg", id="oxyOGGLow",
> > >> name="OxyRadio.net :: Respire et Ecoute!",
> > >> host=oxyHost, port=oxyPort, user=oxyUser,
> > >> password=oxyPassword, genre=oxyGenre, description=oxyDesc,
> url=oxyUrl,
> > >> restart=true,
> > >> radio)
> > >>
> > >> Icecast mountpoint's informations are correct, it prints Quality: 5.
> > >> and Quality: 0. for these mountpoints. But when I'm listening to
> > >> them, only the bd.ogg mountpoint has the correct quality (64kbps).
> > >> I did some test and it seems that if I set a quality > 0 I get a
> > >> 499kpbs bitrate.. And it's not ok according to the wikipedia page :
> > >> http://en.wikipedia.org/wiki/Vorbis#Technical_details
> > >>
> > >> Can you confirm this small bug ?
> >
> > Afaik, the range Liquidsoap uses is 0.0 - 1.0, so quality 5 would be
> > 0.5. A small test on my side confirms this; 0.5 gives 160Kbps streams.
New description:
We should avoid bug reports like the one below: we should check that
quality of
encoding is between 0 and 1 and likewise that other parameters are within
reasonable bounds.
> > I have a little problem using the output.icecast and the new syntax.
> > Here my lines:
> >
{{{
output.icecast(%vorbis(quality=5), mount="hd.ogg", id="oxyOGG",
name="OxyRadio.net :: Respire et Ecoute!",
host=oxyHost, port=oxyPort, user=oxyUser,
password=oxyPassword, genre=oxyGenre, description=oxyDesc, url=oxyUrl,
restart=true,
radio)
output.icecast(%vorbis(quality=0),mount="bd.ogg", id="oxyOGGLow",
name="OxyRadio.net :: Respire et Ecoute!",
host=oxyHost, port=oxyPort, user=oxyUser,
password=oxyPassword, genre=oxyGenre, description=oxyDesc, url=oxyUrl,
restart=true,
radio)
}}}
> >
> > Icecast mountpoint's informations are correct, it prints Quality: 5.
> > and Quality: 0. for these mountpoints. But when I'm listening to
> > them, only the bd.ogg mountpoint has the correct quality (64kbps).
> > I did some test and it seems that if I set a quality > 0 I get a
> > 499kpbs bitrate.. And it's not ok according to the wikipedia page :
> > http://en.wikipedia.org/wiki/Vorbis#Technical_details
> >
> > Can you confirm this small bug ?
>
> Afaik, the range Liquidsoap uses is 0.0 - 1.0, so quality 5 would be
> 0.5. A small test on my side confirms this; 0.5 gives 160Kbps streams.
--
Comment(by toots):
Additionally, we may also use the official ranges, like 0-10 for vorbis...
--
Ticket URL: <http://savonet.rastageeks.org/ticket/338#comment:2>
Savonet <http://savonet.rastageeks.org/>
Let's program our stream !
------------------------------------------------------------------------------
_______________________________________________
Savonet-trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-trac
