#386: De-entangle reset_encoder and metadata...
-------------------------+--------------------------------------------------
Reporter: toots | Owner: toots
Type: TODO | Status: reopened
Priority: 1 | Milestone: 1.0
Component: Liquidsoap | Version: 1.0.beta+svn
Resolution: | Keywords:
Mac: 1 | Linux: 1
Netbsd: 1 | Other: 1
Freebsd: 1 |
-------------------------+--------------------------------------------------
Changes (by toots):
* status: closed => reopened
* resolution: fixed =>
Comment:
Hi yall !
I've realized that the "fix" for this issue was not sufficient and there
was still too much confusion, in particular "restart_on_metadata" was
still not working..
Therefore, I took a step ahader and did the following changes:
* insert_metadata is now of the type: metadata -> unit and is documented
as meant for inline insertion of metadata
* Encoders creation now also needs metadata, which allows to pass initial
metadata when there are some.
I kind of like the fact that it also removes the call to self#send after
seld#insert_metadata and I think overall the patch makes sense.
I am still testing it but it seems to be fine here. Please, make any
comments. If I do not find issues within the next days and no one object,
I will commit it...
--
Ticket URL: <http://savonet.rastageeks.org/ticket/386#comment:5>
Savonet <http://savonet.rastageeks.org/>
Let's program our stream !
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Savonet-trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-trac
