Hi Thomas, Thanks for the fast feedback! I'll document the fix and merge it asap.
Cheers, David On Sat, Oct 26, 2013 at 9:24 PM, "T. Bühlmann" <[email protected]> wrote: > Hi David > > Am 26.10.2013 00:43, schrieb David Baelde: >> FYI I have a proposed fix in branch LS-115 >> (https://github.com/savonet/liquidsoap/commits/LS-115) you're welcome >> to check it out and see if it fixes things for you. For me it does, >> but I need to work a bit more on some of my tests, and sleep, before I >> can close this mess, hopefully for good this time. The issue has been >> around since september 2012! > Well, i hope you had a good night then? :) > > Your fix from branch LS-115 works also for me. > For real-world testing i took my regular script and added a smooth_add() > every minute. > It now runs for over 2 hours without problems. > > smooth_add() is (in my opinion) one the coolest function of LS. > Makes it very easy to add automatich time announcments. > > Thanks again! > > --Tom >> On Fri, Oct 25, 2013 at 3:38 PM, David Baelde <[email protected]> wrote: >>> Thanks for the report Thomas! >>> >>> I'm ashamed that we still/again have a problem with smooth_add. I have >>> reproduced against the very latest version, and files an issue on >>> which I plan to work right now: >>> https://github.com/savonet/liquidsoap/issues/115 >>> >>> Cheers, >>> >>> David >>> >>> On Tue, Oct 22, 2013 at 5:34 PM, Romain Beauxis <[email protected]> >>> wrote: >>>> Ok thanks, will try to reproduce. >>>> >>>> 2013/10/22 Thomas Bühlmann <[email protected]>: >>>>> Am 22.10.2013 17:05, schrieb Thomas Bühlmann: >>>>>> Am 22.10.2013 14:27, schrieb Romain Beauxis: >>>>>>> Hi Thomas, >>>>>>> >>>>>>> 2013/10/9 Thomas Bühlmann <[email protected]>: >>>>>>>> Today i found some time to get latest liquidosoap-full git and compile. >>>>>>>> It's version: Liquidsoap 1.1.1+scm >>>>>>>> (git://github.com/savonet/liquidsoap.git@b7dad534b3c51dfb7f35742cbab806bc92a899f9:20131009:202232) >>>>>>>> There i find he "old" smooth_add bug: it starts fading to special, but >>>>>>>> doesn't return to normal. >>>>>>>> It just sits at >>>>>>>> >>>>>>>> [single_4944:3] Finished with "/music/news/time.mp3". >>>>>>>> [amplify_4948:3] End of the current overriding. >>>>>>>> and can only be killed. >>>>>>>> >>>>>>>> The same script works with an older version. >>>>>>>> In my case: Liquidsoap 1.1.1+scm >>>>>>>> (git://github.com/savonet/liquidsoap.git@dfcf79c10c580abcd35451799f99deeb46d0bfd8:20130825:110844) >>>>>>>> The code basically looks like this: >>>>>>>> >>>>>>>> sa=playlist.safe(...) >>>>>>>> sa=amplify(1.,override="replay_gain",day) >>>>>>>> >>>>>>>> sb=single ("annotate:foo=\"bla\":/music/news/time.mp3") >>>>>>>> .... >>>>>>>> ..... >>>>>>>> radio=smooth_add(delay=0.9,p=0.3, normal=sa, special=switch([({(1h-6h) >>>>>>>> and >>>>>>>> 00m00s),sb)])) >>>>>>>> >>>>>>>> output.icecast(.... ,radio) >>>>>>>> >>>>>>>> Can anybody confirm this or is there an error on my side? >>>>>>> We recently fixed a bug in smart_crossfade that sounds similar to >>>>>>> this. Can you reproduce the issue with the current git code? >>>>>>> >>>>>>> Thanks, >>>>>>> Romain >>>>>> Hi Romain >>>>>> In this case I'll fetch git again this evening and retry. >>>>>> >>>>>> Thanks, >>>>>> Tom >>>>> Hello! >>>>> >>>>> I already had time to fetch latest git. >>>>> I have now: >>>>> Liquidsoap 1.1.1+scm >>>>> (git://github.com/savonet/liquidsoap.git@b7dad534b3c51dfb7f35742cbab806bc92a899f9:20131022:172243) >>>>> >>>>> Unfortunately the error persists. :( >>>>> >>>>> --Tom >>>>>>> ------------------------------------------------------------------------------ >>>>>>> October Webinars: Code for Performance >>>>>>> Free Intel webinars can help you accelerate application performance. >>>>>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the >>>>>>> most from >>>>>>> the latest Intel processors and coprocessors. See abstracts and >>>>>>> register > >>>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk >>>>>>> _______________________________________________ >>>>>>> Savonet-users mailing list >>>>>>> [email protected] >>>>>>> https://lists.sourceforge.net/lists/listinfo/savonet-users >>>>>> ------------------------------------------------------------------------------ >>>>>> October Webinars: Code for Performance >>>>>> Free Intel webinars can help you accelerate application performance. >>>>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most >>>>>> from >>>>>> the latest Intel processors and coprocessors. See abstracts and register >>>>>> > >>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk >>>>>> _______________________________________________ >>>>>> Savonet-users mailing list >>>>>> [email protected] >>>>>> https://lists.sourceforge.net/lists/listinfo/savonet-users >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> October Webinars: Code for Performance >>>>> Free Intel webinars can help you accelerate application performance. >>>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most >>>>> from >>>>> the latest Intel processors and coprocessors. See abstracts and register > >>>>> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk >>>>> _______________________________________________ >>>>> Savonet-users mailing list >>>>> [email protected] >>>>> https://lists.sourceforge.net/lists/listinfo/savonet-users >>>> ------------------------------------------------------------------------------ >>>> October Webinars: Code for Performance >>>> Free Intel webinars can help you accelerate application performance. >>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most >>>> from >>>> the latest Intel processors and coprocessors. See abstracts and register > >>>> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk >>>> _______________________________________________ >>>> Savonet-users mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/savonet-users >>> >>> >>> -- >>> David >> >> > > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk > _______________________________________________ > Savonet-users mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/savonet-users -- David ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk _______________________________________________ Savonet-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/savonet-users
