Thanks a lot! I'll spend some time updating it probably either tomorrow or
early next week.
On 03 Aug 2018, 17:46, at 17:46, Romain Beauxis <notificati...@github.com>
wrote:
>Here are my notes:
>- `dh_autoreconf` gave me grief. `./bootstrap` worked great, tho.
>- `dh_auto_test` failed, git repo is missing the test dirs (`src/test`
>and `scripts/test` at least). I would disable it anyways.
>- Had to modify `dh_autoinstall`.
>- Had to modify `liquidsoap.install`. Not sure if everything is
>correct, haven't checked the standard practices there in a long while..
>- I would suggest simply dropping liguidsoap. It hasn't been maintained
>in ages.
>
>Other that, it looks great and all available options in `main` compile.
>That's a lot of ground work to push all these update, hats off!
>
>Final diff:
>```
>diff --git a/debian/liguidsoap.install b/debian/liguidsoap.install
>index 1fde12d..eb4cfe4 100644
>--- a/debian/liguidsoap.install
>+++ b/debian/liguidsoap.install
>@@ -1,4 +1,4 @@
> debian/tmp/usr/bin/liguidsoap
>-debian/tmp/usr/lib/python*/site-packages/liquidsoap/*
>var/lib/liguidsoap
>+debian/tmp/usr/lib/*/python*/site-packages/liquidsoap/*
>var/lib/liguidsoap
> debian/icons/* usr/share/pixmaps
> debian/liguidsoap.desktop usr/share/applications
>diff --git a/debian/liquidsoap.install b/debian/liquidsoap.install
>index fada731..a1625dc 100644
>--- a/debian/liquidsoap.install
>+++ b/debian/liquidsoap.install
>@@ -1,5 +1,6 @@
> debian/tmp/usr/bin/liquidsoap
>-debian/tmp/usr/lib/liquidsoap
>+debian/tmp/usr/lib/*/liquidsoap
> debian/tmp/etc/logrotate.d/liquidsoap
>-examples/radio.liq etc/liquidsoap
>-NODYN: debian/tmp/@OCamlStdlibDir@/liquidsoap/dllliquidsoap.so
>@OCamlDllDir@
>+debian/tmp/usr/share/doc/liquidsoap-* usr/share/doc/liquidsoap
>+debian/tmp/usr/share/man/man1
>+debian/tmp/etc/liquidsoap/radio.liq.example usr/share/doc/liquidsoap
>diff --git a/debian/rules b/debian/rules
>index 1033a80..50ee0f5 100755
>--- a/debian/rules
>+++ b/debian/rules
>@@ -2,18 +2,26 @@
>
> include /usr/share/ocaml/ocamlvars.mk
>
>-DESTDIR := $(CURDIR)/debian/tmp/$(OCAML_STDLIB_DIR)
>+DESTDIR := $(CURDIR)/debian/tmp
>
> %:
> dh $@
>
>+
>+override_dh_autoreconf:
>+ ./bootstrap
>+
> override_dh_auto_build:
> [ -f debian/autoreconf.before ] || dh_autoreconf
> $(MAKE) all doc
>
>+override_dh_auto_test:
>+
> override_dh_auto_install:
> mkdir -p $(DESTDIR)
>- $(MAKE) install OCAMLFIND_DESTDIR=$(DESTDIR)
>OCAMLFIND_LDCONF=ignore
>+ $(MAKE) install DESTDIR=$(DESTDIR)
>OCAMLFIND_DESTDIR=$(DESTDIR)/$(OCAML_STDLIB_DIR) \
>+ prefix=$(DESTDIR)/usr sysconfdir=$(DESTDIR)/etc \
>+ INSTALL_DAEMON=no OCAMLFIND_LDCONF=ignore
> dh_install --fail-missing
>
> override_dh_auto_clean:
>```
>
>--
>You are receiving this because you were mentioned.
>Reply to this email directly or view it on GitHub:
>https://github.com/savonet/liquidsoap/issues/398#issuecomment-410294677
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/savonet/liquidsoap/issues/398#issuecomment-410430887
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Savonet-users mailing list
Savonet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-users
